Giter VIP home page Giter VIP logo

Comments (7)

torfjelde avatar torfjelde commented on June 11, 2024 1

The {..., Dims=1} in Composed. After #44 we'll have dimension information in Bijector, and in the case of these "wrapper" bijectors, e.g. Composed, it could be nice to show the dimensionality of the bijector:)

from bijectors.jl.

trappmartin avatar trappmartin commented on June 11, 2024 1

I see, I think the dims is a good idea.

from bijectors.jl.

torfjelde avatar torfjelde commented on June 11, 2024 1

You can see how the README will look with dimensionality from PR #44 combined with the proposed Base.show overload over at https://github.com/torfjelde/Bijectors.jl/tree/tor/show-overload

from bijectors.jl.

trappmartin avatar trappmartin commented on June 11, 2024

How does 1 differ from 2?

from bijectors.jl.

torfjelde avatar torfjelde commented on June 11, 2024

We can also drop the Dims= and just write the dimensionality N, which is similar to what you get by default for all other bijectors, e.g. Exp() is displayed as Exp{0}() because by default we assume Exp to be 0-dimensional (can also instantiate as Exp{N}() where N is an integer)

from bijectors.jl.

trappmartin avatar trappmartin commented on June 11, 2024

Would it make sense to use lower-case dim instead of Dim? I think this would be more julia style.

from bijectors.jl.

torfjelde avatar torfjelde commented on June 11, 2024

I'm not necessarily against that; my reasoning for choosing Dim is because it's a type-parameter rather than an argument. Could also rename to D or dim as you suggested :)

from bijectors.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.