Comments (8)
I looked into the detail of test coverage and wonder if those functions that haven't been used are just abandoned.
from turing.jl.
I can't remember what functions are not used; can we remove obviously obsolete functions, but keep potentially useful functions somewhere separately (ie. not affecting test coverage).
from turing.jl.
Keep runtest.jl structured
Please check the new runtest.jl file. When adding new tests in the future, keep it structured using the current way so that we can tell which source file we are testing for each test case.
It makes a lot sense to do it this way!
Review of old test cases
I noticed some comments in them are out-of-date. @yebai Can you also have a check and remove unnecessary ones.
Yes, I will take a look!
from turing.jl.
PS. can we create a separate branch (e.g. test-coverage) and keep all work related there?
from turing.jl.
I can't remember what functions are not used; can we remove obviously obsolete functions, but keep potentially useful functions somewhere separately (ie. not affecting test coverage).
I guess we can either
- Create a branch called old-development and come back when some functions are needed, or
- Create a folder called old-src or something in the root path of Turing
Which one do you think is better?
PS. can we create a separate branch (e.g. test-coverage) and keep all work related there?
I wonder whether a separate branch for test coverage is a good idea as we need keep running these updated testes for our updated code.
from turing.jl.
Create a branch called old-development and come back when some functions are needed
Let's do this.
I wonder whether a separate branch for test coverage is a good idea as we need keep running these updated testes for our updated code.
In general we should avoid commit work in progress directly to development or master. Instead, we can keep a new branch for each new task, and create a PR towards to development/master when it is done.
from turing.jl.
The coverage is 85% after removal these files.
In general we should avoid commit work in progress directly to development or master. Instead, we can keep a new branch for each new task, and create a PR towards to development/master when it is done.
Yeah! I'll stick to this as well.
BTW, do you keep the old-development
locally?
from turing.jl.
@yebai I wonder if src/distributions/distributions.jl
should also be removed?
The flatten
function inside is not used anywhere else.
from turing.jl.
Related Issues (20)
- AbstractMCMC docs page out of date HOT 1
- Attempt fixing `bnn` tests in Ezyme PR HOT 3
- Make MLE and MAP more robust HOT 6
- Depreciate MCMC-interface code in favour of `AbstractMCMC`.
- Fix code test coverage HOT 1
- preallocating an array of random variables, getting `varname As used multiple times in model (subsumes As[1])` HOT 1
- maximum_likelihood function not found in Turing.jl HOT 4
- Allow for a named tuple for `initial_params` HOT 13
- Using the score function estimator as gradient for VI HOT 9
- Import style and modularisation HOT 9
- JuliaFormatter GHA workflow fails on public forks due to insufficient permissions HOT 2
- Turing fails to precompile due to deprecated method dispatches with v1.10 HOT 6
- Distributions defined in Turing: is the plan to keep them here? HOT 2
- Slice sampling as a `Gibbs` sampler HOT 5
- Safety for poisson random calls HOT 6
- Multithread tests fail on master HOT 6
- Interface for specifying adjoints of FEM models HOT 9
- Julia 1.7 tests are failing HOT 9
- Support potential type argument in rand for eltype of Sampleable HOT 1
- Refactoring AD Tests
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from turing.jl.