Giter VIP home page Giter VIP logo

Comments (7)

EmilyMB avatar EmilyMB commented on July 22, 2024

Grumble: For multi-line strings, I'm not sure why they prefer string concatenation ("+") to splitting with "".
Happy about: most of it, especially descriptive naming.

from intermission-assignments.

nathanows avatar nathanows commented on July 22, 2024

Not sure my JS is strong enough to have any real opinion on any of these but... yeah.

  • Single quoting strings... not sure why on this one. I guess with no-interpolation its just not important and they arbitrarily picked single? Hound kind of engrained the double quotes in me
  • The Properties section is interesting, not sure i get why to use dot notation in one context and [] syntax in the other.
  • mutli-line var declarations: For unassigned var's i kind of like the multi assignment
  • use shortcuts: 👍 specifically this one was kind of cool (if (collection.length) instead of if(collection.length > 0))
  • I like the standardized FIXME and TODO comment keywords (but guessing these are just bad practice to use)?
  • Soft tabs: 2: 👍 👍 👍 I hate hard tabs
  • Semicolons: Yep.
  • Camel case Var names could be tough after so much ruby
  • I think i like the leading underscore on private methods
  • Prefixing jQuery var names with $ is interesting... i kind of like it...

from intermission-assignments.

KristaANelson avatar KristaANelson commented on July 22, 2024

I actually really appreciate this guide! I love that they show bad examples and good examples for each topic! I also like that they point out what not to make things. I never know and then get weird things happening because I ised a key word.
I'm not sure if I get the difference when to use the dot notation yet vs subscript. Hopefully that will click.

Hoisting confuses me.

this. I'm also still getting familiar with. I was thinking it was just like self in Ruby but now I'm not so sure.

Bookmarking this!

from intermission-assignments.

Lydias303 avatar Lydias303 commented on July 22, 2024

I am still confused about hoisting... I think I may prefer the explanation in chapter 15 about hoisting better this one.

I like the examples! I think I will definitely be referring back to this.

I like the comment prefix's. I think that is good for clarity.

Call me crazy but I see zero difference between the 3 examples on "End files with a single newline character."
// bad
(function(global) {
// ...stuff...
})(this);

// good
(function(global) {
// ...stuff...
})(this);↵

from intermission-assignments.

laurawhalin avatar laurawhalin commented on July 22, 2024

This stylesheet seems to help you avoid some common pitfalls, unlike the thoughtbot guide for ruby, which just made clear some style choices. One place I really noticed this was in the Constructors section, when assigning methods to the prototype object.
Definitely a good reference, especially seeing how many other companies use it!

from intermission-assignments.

bmrsny avatar bmrsny commented on July 22, 2024

I like the examples. I think for someone who may be new to a language can benefit a lot, I know I did. Some of these were a little more confusing, and took more glancing over. I did find a few spots where they suggested //bad, then a few examples later they would make a case for why it is ok. Think my JavaScript skills need some more work. Will be referencing more!

from intermission-assignments.

mikedao avatar mikedao commented on July 22, 2024

I don't think that I am familiar with Javascript enough to really have an informed opinion, but I'll certainly follow the style guide, much smarter people than I came up with it, so I'm sure they had good reasons for their choices.

from intermission-assignments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.