Giter VIP home page Giter VIP logo

Comments (5)

kristinabrown avatar kristinabrown commented on August 25, 2024

Well, none of it really made me jump out of my chair. I do think it's really important to have a set style, especially when so many things in Ruby are optional. The thing that did make me grumble a little bit was the "don't misspell" thing, I don't see why that was necessary, as if some developers misspell things on purpose as a personal style choice... (I misspell things a lot, but not on purpose, I usually correct it when it's pointed out)

from intermission-assignments.

michelleambrisco avatar michelleambrisco commented on August 25, 2024

There are definitely a few rules I had not been following like using detect over find and adding a trailing comma but I agree with Kristina none of it seemed unreasonable and it is good to pick a style and stick with it.

from intermission-assignments.

tessgriffin avatar tessgriffin commented on August 25, 2024

I agree with Kristina and Michelle that nothing really stood out as something I'd hadn't seen before (or something that Hound pointed out). I think in general it's important to get used to following some type of style guide. Presumably the job you'll get will have one, and if you plan to contribute to any large open source project (like Rails) they will definitely not merge your stuff in if it doesn't follow their guides.

from intermission-assignments.

saltybigmac avatar saltybigmac commented on August 25, 2024

This style guide makes me happy because it's everything I already do :) I have always hated ternary operators because I think they are hard to read, and I feel validated that they don't use them either. The protected over private is interesting. I didn't know you could do that. I like being able to follow a style guide so that code can be consistent not only throughout one project, but throughout all of them. Especially while working at a company, that way when reading someone else's code you will likely be able to follow it easier.

from intermission-assignments.

NYDrewReynolds avatar NYDrewReynolds commented on August 25, 2024

There was a lot I agreed with on the Style Guide and a few I disagree with. For example, I don't see problems using ternary operators for simple if statements. I also think find & find_all are more descriptive than detect & select. Also, we were taught to use private instead of protected. I have actually never seen protected until now.

from intermission-assignments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.