jQuery version conflict? about moodle-mod_turnitintooltwo HOT 9 CLOSED

Hi @andrewrowatt-masseyuni

This sounds like a conflict with the custom theme as we have not seen this problem on our development environments. For the plugin we only develop and test against the default Moodle theme.

from moodle-mod_turnitintooltwo.

Hi @andrewrowatt-masseyuni
The turnitintooltwo plugin loads jQuery 1.8.2 IFF the Moodle version is 2.5 or lower, as 2.6 onwards came packaged with its own jQuery.
I've added similar logic to plagiarism_turnitin that should get released soon. In the meantime, if your workaround of blocking 1.8.2 is effective and not causing problems, then there should be no reason not to continue with that arrangement in the interim.
Kind regards
David

from moodle-mod_turnitintooltwo.

Hi @andrewrowatt-masseyuni
I have built in such a catch, but upon testing it started generating errors in the submission inbox. These errors are non-fatal and will only be visible with debugging switched on.
I have created issue #129 regarding these messages to flag them as a known issue.

from moodle-mod_turnitintooltwo.

Note: theme is:
https://github.com/moodlerooms/moodle-theme_snap

from moodle-mod_turnitintooltwo.

Hi David et al,

Unfortunately the blocking solution was merely used to confirm that the duplicate loading of jQuery was the issue. I cannot use this as a workaround as the issue impacts students and teachers plus a complicating factor is that only some courses are using the alternative theme.

So, in short I do need a permanent and robust solution. Is there anything I can do to help?

Andrew

P.S.
I note that turnitintooltwo.js contains the line:
//var tiijq = jQuery.noConflict();

Which suggests version conflicts have been considered previously.

from moodle-mod_turnitintooltwo.

Hi @andrewrowatt-masseyuni
Thanks for providing us with a link to the theme. Our tests were initially conducted on the default Moodle but the source showed that despite the debugging output, jQuery 1.11.1 loaded as expected.
If you have a development/testing environment then the jQuery_loading branch of my repository will enable you to test the results of the modifications. Hopefully they will work for you.
Thanks
David

from moodle-mod_turnitintooltwo.

Thanks David! I will pass that onto my local team.

from moodle-mod_turnitintooltwo.

Hi @andrewrowatt-masseyuni - unfortunately I don't think we are able to fix this. The plagiarism API in Moodle doesn't allow us to include jquery in the correct way so we have to use $PAGE->requires->js().

Does everything work ok for you still with that line removed? If so, I don't see a problem with you leaving it out.

from moodle-mod_turnitintooltwo.

/**
* Load JS needed by the page.
*/
public function load_page_components() {
global $CFG, $PAGE;
// replace these two lines
// $jsurl = new moodle_url($CFG->wwwroot.'/plagiarism/turnitin/jquery/jquery-1.8.2.min.js');
// $PAGE->requires->js($jsurl);
// with this

   $PAGE->requires->jquery();

/plagiarism/turnitin/lib.php

from moodle-mod_turnitintooltwo.