Error on Moodle Import about moodle-mod_turnitintooltwo HOT 7 CLOSED

Afternoon

I work for blackboard and we can confirm this issue occurs using version 2016011105 of the assignment module, the error which gets generated is as per below

Debug info:
Error code: There was an error trying to create the assignment in Turnitin

Fault Code: invaliddata | File: [dirroot]/mod/turnitintooltwo/sdk/assignmentsoap.class.php | Line: 33 | Message: date_start - start date can not be more than 1 year in the past.
| Code: 0
$a contents: There was an error trying to create the assignment in Turnitin

Fault Code: invaliddata | File: [dirroot]/mod/turnitintooltwo/sdk/assignmentsoap.class.php | Line: 33 | Message: date_start - start date can not be more than 1 year in the past.
| Code: 0
Stack trace

This is being caused by the public function createAssignment( $assignment ) function as the code cant tell if it is being called by the moodle restore or import library below is the entire call stack for this error which should show the parent functions
line 488 of /lib/setuplib.php: moodle_exception thrown
line 683 of /mod/turnitintooltwo/lib.php: call to print_error()
line 149 of /mod/turnitintooltwo/turnitintooltwo_comms.class.php: call to turnitintooltwo_print_error()
line 842 of /mod/turnitintooltwo/turnitintooltwo_assignment.class.php: call to turnitintooltwo_comms::handle_exceptions()
line 1385 of /mod/turnitintooltwo/turnitintooltwo_assignment.class.php: call to turnitintooltwo_assignment::create_tii_assignment()
line 125 of /mod/turnitintooltwo/backup/moodle2/restore_turnitintooltwo_activity_task.class.php: call to turnitintooltwo_assignment->edit_moodle_assignment()
line 111 of /backup/util/plan/restore_task.class.php: call to restore_turnitintooltwo_activity_task->after_restore()
line 193 of /backup/util/plan/restore_plan.class.php: call to restore_task->execute_after_restore()
line 121 of /backup/moodle2/restore_final_task.class.php: call to restore_plan->execute_after_restore()
line 717 of /backup/moodle2/restore_stepslib.php: call to restore_final_task->launch_execute_after_restore()
line 34 of /backup/util/plan/restore_execution_step.class.php: call to restore_execute_after_restore->define_execution()
line 190 of /backup/util/plan/base_task.class.php: call to restore_execution_step->execute()
line 177 of /backup/util/plan/base_plan.class.php: call to base_task->execute()
line 167 of /backup/util/plan/restore_plan.class.php: call to base_plan->execute()
line 333 of /backup/controller/restore_controller.class.php: call to restore_plan->execute()

from moodle-mod_turnitintooltwo.

Hi @sharpchi and @barry-matthias ,

We have fixed this in our current development build so it will go out with the next release of the V2 plugin.

from moodle-mod_turnitintooltwo.

Thanks for letting us know. I'm not entirely sure it is fixed, though. In the turnitintooltwo_assignment.class.php file you have this line:

if (($restore) && ($attribute < strtotime("-1 year"))) {

which checks the $attribute value. I would expect that value to be a timestamp, but $attribute is set just a few lines up to:

$attribute = "maxmarks".$i;

Would you mind checking please?

from moodle-mod_turnitintooltwo.

Hi @sharpchi ,

Thanks for pointing that out, after looking at it myself I do indeed see a bug in our fix. We haven't done our full sweep of QA and automations yet for the next release so we hadn't spotted it yet.

We will amend this before the release.

from moodle-mod_turnitintooltwo.

So, I think you need something like this:

$attribute = "dtstart".$i;
if (($restore) && ($this->turnitintooltwo->$attribute < strtotime("-1 year"))) {

from moodle-mod_turnitintooltwo.

Hi @sharpchi ,

Yeah this is the fix I had in mind. From my testing the fix you propose does work as intended. We'll get it through QA as soon as we can as we aim to release soon.

from moodle-mod_turnitintooltwo.

Fixed in v2016091401

from moodle-mod_turnitintooltwo.