Enhance ellipsis component about naive-ui HOT 3 OPEN

As far as I know there would be some edge cases for js dom slicing and measuring based ellipsis. For example non-text inline element is hard to deal with. (and i think it may break vue's patching phase (when user changes slot content).

I'm not planning to do it.

However if you have knowledge about how to solve those problems. PR is welcomed.

from naive-ui.

@07akioni I agree with you, how to judge the row count(1 or multiple of text's line-height) of a non-text inline element(higher than text) is divergent. I compute total height by text's line-height and line-clamp in react-ellipsis to avoid the edge cases, but it can't be suit to any case actually. Never mind js slicing here, but maybe add a prop to control whether clamp could be better?

from naive-ui.

@07akioni I agree with you, how to judge the row count(1 or multiple of text's line-height) of a non-text inline element(higher than text) is divergent. I compute row count by text's line-height and line-clamp in react-ellipsis to avoid the edge cases, but it can't be suit to any case actually. Never mind js slicing here, but maybe add a prop to control whether clamp could be better?

I think it's okay. If you want to use custom ellipsis, you need to ensure only text is passed in.

from naive-ui.