Giter VIP home page Giter VIP logo

Comments (5)

tuurbo avatar tuurbo commented on July 24, 2024

Yes, a PR is fine with me

from spreedly.

lasergoat avatar lasergoat commented on July 24, 2024

@tuurbo I just had a thought, but I'm not sure how to implement. I could also make a facade and override the Client.php class but I'm not sure how I would get my code to load that new file instead of the normal file.

from spreedly.

tuurbo avatar tuurbo commented on July 24, 2024

If I understand your comment, wouldn't you just remove any Tuurbo\Spreedly\... lines and add to your config/app.php file

'providers' => [
    ...
    MyApp\Foo\CustomSpreedlyServiceProvider::class,
],
'aliases' => [
    ...
    'Spreedly' => MyApp\Foo\CustomSpreedlyFacade::class,
]

from spreedly.

lasergoat avatar lasergoat commented on July 24, 2024

@tuurbo another question about this - I couldn't quite figure out how to override it, so I'm proceeding with my original plan of including base url in the config so it can be set through Spreedly::mergeConfig().

It took me a couple minutes to figure out how to run the unit tests. Would you be opposed to me adding a package.json simply so people can do npm test to run phpspec? Also, I can update the readme with test instructions for development. Any opposition?

from spreedly.

lasergoat avatar lasergoat commented on July 24, 2024

PR #31

from spreedly.

Related Issues (15)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.