Comments (7)
This is very important now since Twisted 16.0.0 removed the deprecated attribute, so Nevow will be broken once that is out.
from nevow.
Okay, nevermind, the breakage was fixed in c1ba6f1, just need to do another release.
from nevow.
Tahoe's unit tests (along with all actual functionality) will break if Twisted-16.0.0 comes out before the new Nevow release.. is there anything we can do to help the Nevow release along? I think 16.0.0 is in the pipeline, so the clock is ticking :)
refs: https://tahoe-lafs.org/trac/tahoe-lafs/ticket/2732
from nevow.
Yeah, I have a bunch of stuff that'll break too :) I'm going to try get a release out today or tomorrow. (16.0.0 prerelase is out, but I think we've got a few days at least before a final).
from nevow.
There are probably backwards-compatibility issues I'm not aware of, but am I correct in thinking that we'll still get self-inflicted deprecation warning with c1ba6f1 and the new release? It looks like NevowRequest.process()
still uses self.received_headers
, which is implemented as a (Nevow-provided, Nevow-deprecated) property that wraps a (Nevow-provided) _DictHeaders
around the modern twisted.web self.requestHeaders
.
That's not as severe as breaking entirely, but it sounds like we should still expect to see DeprecationWarnings
in our test run. Except that now it will be Nevow complaining about it's own code, rather than Twisted complaining about Nevow. Sound about right?
from nevow.
Yes, that's correct; and apparently this code path isn't tested? At least, I didn't see the warning during a test run on #69. I'll try to fix it in another branch, though. Hopefully then Nevow shouldn't be tripping its own warnings or Twisted's.
from nevow.
@warner Just released 0.13.0!
from nevow.
Related Issues (20)
- Python 3 compatibility? HOT 19
- Microsoft Edge 42.17134.1.0 breaks Divmod/Runtime/getAtrribute HOT 3
- IResource compatibility layer breaks on leaf resources with pre/postpath manipulation
- nevow.test.test_compression.RequestWrapperTests.test_contentLength fails against Twisted trunk@HEAD
- Flattening an attribute value fails to quote it satisfactorily HOT 4
- Remove Athena duplicate message log entry
- `connectionMade` is sometimes called too late HOT 1
- NevowRequest.received_headers / headers are deprecated and should be removed
- Put nevow.taglibrary.tabbedPane back
- Add some extra compatibility assistance in FakeRequest
- nevow.compression refers to deprecated header attributes
- Use towncrier for maintaining a changelog
- Nevow tests fail on Twisted 16.3
- Unable to get property 'length' of undefined or null reference
- `PageWidget.action_respond` is sometimes invoked with a nonexistent response identifier
- SVG wrong mimetype text/html instead of 'image/svg+xml'
- Nevow 0.14.1 release
- Remove widget initialization log messages
- Nevow uses now-removed FilePath.getmtime(), causes exception HOT 4
- Athena client-side timeout
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from nevow.