Comments (21)
Automation removed owner |
---|
from twisted.
ne1uno commented |
---|
#!html
<pre>
$ python trial.py --package=twisted.test --reactor=win32 --
verbose
$ python trial.py --reactor=win32 --verbose --
package=twisted.test
Using twisted.internet.win32 reactor
Traceback (most recent call last):
File "trial.py", line 35, in ?
run()
File "L:\c\Python22\Lib\site-
packages\twisted\scripts\trial.py", line 213, in
run
config.parseOptions()
File "L:\c\Python22\Lib\site-
packages\twisted\python\usage.py", line 192, in p
arseOptions
self.__dispatch[optMangled](optMangled, arg)
File "L:\c\Python22\Lib\site-
packages\twisted\python\usage.py", line 343, in <
lambda>
fn = lambda self, name, value, m=method: m(value)
File "L:\c\Python22\Lib\site-
packages\twisted\scripts\trial.py", line 63, in o
pt_reactor
reflect.namedModule(mod).install()
File "L:\c\Python22\Lib\site-
packages\twisted\python\reflect.py", line 369, in
namedModule
topLevel = __import__(name)
ImportError: No module named win32
> l:\c\python22\lib\site-packages\twisted\python\reflect.py
(369)namedModule()
-> topLevel = __import__(name)
(Pdb)
hope its not user error on my part.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
You need to pass "--reactor==win32eventreactor". The issue
is that the command line argument is different than
twistd's. Not sure why!
</pre>
from twisted.
@radix commented |
---|
#!html
<pre>
It's that way because maintaining dictionaries mapping names
to reactor modules is annoying (I implemented this
functionality of trial :).
It would be nice to move twistd's mapping to somewhere in
twisted.internet, and then have twistd and trial both use
it. This is a non-bug, though, so I'm marking it as wishlist.
</pre>
from twisted.
ne1uno commented |
---|
#!html
<pre>
obviously the --help needs updating then.
thanks.
btw, color output is fine on win9x if you load the
driver in config.sys
device= C:\Windows\COMMAND\ANSI.SYS
there are other problems running trial from msys the bash
shell for mingw but thats for another issue.
</pre>
from twisted.
@radix commented |
---|
#!html
<pre>
dunno why this was set to "bug" and "resolved", I put it
back to "feature" and "chatting"...
</pre>
from twisted.
@radix commented |
---|
#!html
<pre>
dunno why this was set to "bug" and "resolved", or why the
title reverted... I'm unreverting those changes
</pre>
from twisted.
@jdavisp3 commented |
---|
#!html
<pre>
Just fooling around, here's a patch to fix this.
There didn't seem to be an obvious module to put
the table in, so I made a new one twisted.internet.reactors.
I made trial support both the old and new style reactor
arguments for backwards compatibility.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
A better way to do backwards compatability is to just add
more entries to the dictionaty, rather than doing the
loadModule code. Other than that, the patch looks pretty
good, having a central registry is good (We can add
registration function later on, so 3rd parties can register
their own reactors.)
</pre>
from twisted.
@jdavisp3 commented |
---|
#!html
<pre>
One problem with adding the old names to the dictionary
is that the dictionary is used to print out a list of
reactor names for help. It would be confusing to print
out two names for each reactor, I think. I could extend
the dictionary to distinguish between canonical names and
synonyms, perhaps.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
A synonyms dict would work, or having main one map from
{canonical-name: (module, [synonym1, synonym2...]}.
</pre>
from twisted.
@jdavisp3 commented |
---|
#!html
<pre>
Here's a new patch with a synonym table. I also added
some API for getting the reactor names and installing
reactors by name.
I notice Moshe's latest twistd refactor is unix-only.
Perhaps the reactor table needs to distinguish reactors
based on platform?
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
Moshe, please comment.
</pre>
from twisted.
m@... commented |
---|
#!html
<pre>
On Mon, 28 Jul 2003, Itamar Shtull-Trauring <twisted.roundup@...> wrote:
> Moshe, please comment.
If we decide to fix it at all, which I'm not sure is important as
long as reactors are documented in both manpages, we should made
trial to fit twistd, possibly via getting the dictionary in scripts.twistd
--
Moshe Zadka -- http://moshez.org/
Buffy: I don't like you hanging out with someone that... short.
Riley: Yeah, a lot of young people nowadays are experimenting with shortness.
Agile Programming Language -- http://www.python.org/
</pre>
from twisted.
@jdavisp3 commented |
---|
#!html
<pre>
Here's a much simpler patch that uses the dictionary
from scripts.twistd in trial, also supporting b/c.
The patch to usage.py is still necessary to fix the
help output of trial.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
We'll revisit this once moshez merges his app refactor
post-1.0.7.
</pre>
from twisted.
@jdavisp3 commented |
---|
#!html
<pre>
Sounds good. I'm going to commit the usage.py patch
since it fixes the help display of the current version
of trial as well.
</pre>
from twisted.
@itamarst commented |
---|
#!html
<pre>
New application package is in, so we should finish dealing
with this issue.
</pre>
from twisted.
@moshez commented |
---|
#!html
<pre>
Basically, this just requires sticking a call to
twisted.application.app.installReactor in
twisted.scripts.trial -- modulo thinking of backwards
compat. Since Brian is the heaviest automated user, he is
taking responsibility for this.
</pre>
from twisted.
@warner commented |
---|
#!html
<pre>
I've changed trial to use app.installReactor, and
implemented the documentation update from davep's patch. The
BuildBot has been updated to use the new reactor names when
it runs the "reactors" series of tests.
</pre>
from twisted.
@warner commented |
---|
#!html
<pre>
buildbot is running all the correct tests
</pre>
from twisted.
Related Issues (20)
- Change documentation for optional dependency SOAPpy to SOAPpy-py3 HOT 6
- Remove the soap code
- `twisted.internet.test.test_tcp.AbortConnectionTests_*Tests.test_fullWriteBuffer` test timeout on macOS HOT 13
- TwistedWeb ReverseProxyResource example has string not bytes as third argument
- Setup benchmarks using Codspeed.io HOT 6
- Speed up twisted.web server, part 2 of N
- Deprecate t.w.h.HTTPClient HOT 4
- t.w.h.HTTPClient parses Content-Length laxly HOT 1
- disttrial / `trial -j` should support debug prints
- `twisted.python.test.test_sendmsg.SendmsgTests.test_sendSubProcessFD` is flaky HOT 2
- Deprecation docs should use NEXT placeholders
- Improve defer.inlineCallbacks tests
- twisted.web generates deprecation warnings internally HOT 4
- Expand benchmarks to run on PyPy as well HOT 2
- ``twisted.python.code`` package proposal HOT 8
- Performance benchmarks for Deferreds
- Instantiating multiprocessing.SimpleQueue() from an imported package fails unless SimpleQueue() is instantiated inside Twisted application first HOT 9
- http logger should respect the encoding of its log outputs HOT 2
- Update twisted.words.protocol.irc to use IRCv3 HOT 3
- IndexError due to empty args in OpenSSL.SSL.ZeroReturnError handling in Twisted HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twisted.