Not bootstrap 4 ready about formsy-react-components HOT 5 CLOSED

Glad you've been finding this package handy!

Go ahead and fork! I'd be interested to see what's involved. You're right, I ought to create a branch for Bootstrap 4.

I guess you've seen the Bootstrap 4 migration guide for forms?

I'm not sure about what to support once Bootstrap 4 comes out -- my current thinking is that once Bootstrap 4 is released we'll put the Bootstrap 3 code into maintenance mode and make a major release supporting Bootstrap 4. From then on new features will be Bootstrap 4 only. I'm thinking It would be best to avoid flags to switch rendering between Bootstrap 3 and 4.

The older version will obviously still work with Bootstrap 3 and may get some patch updates, but I'm not really keen on supporting 2 versions of Bootstrap simultaneously.

from formsy-react-components.

Hello again, I finally got around to putting this together. (https://github.com/afgarcia86/formsy-react-components). I also updated the playground so that it would be easier to test.

Notes:

• I actually made the label optional, basically I wanted the elementOnly however I wanted it wrapped in the "form-group" which is actually required for the validation classes I believe
• I removed the icon from input since its now added with CSS, however I also removed it from the file input since I don't think it really added much there.

from formsy-react-components.

Hi @afgarcia86, looks good. I've created a new branch for Bootstrap 4 development (bootstrap-4-dev). If you like and at your convenience, you can create a PR and I'll merge it in.

Your notes are noted! I'm thinking of dropping the elementOnly layout, so think just not rendering the label if it isn't provided is okay. Nuking the icon is fine.

from formsy-react-components.

Hi @twisty @afgarcia86,

I've been trying to use the branch because I'm using bootstrap v4.
After installing through
yarn add https://github.com/twisty/formsy-react-components.git#bootstrap-4-dev

I see the following error :
Module not found: Error: Can't resolve 'formsy-react-components'
Field 'browser' doesn't contain a valid alias configuration

I'm using :
[email protected]
[email protected]
[email protected]

Please, advise, thanks !

from formsy-react-components.

FF on this. How are we going to use the formsy for bootstrap 4? thanks!

from formsy-react-components.