Giter VIP home page Giter VIP logo

Comments (9)

twisty avatar twisty commented on May 31, 2024

Hi @copas2,

Thanks for the heads-up, I'll look into it.

from formsy-react-components.

franklinkim avatar franklinkim commented on May 31, 2024

+1

maybe even mark react as peerDependencies like in formsy-react's package.json!? (might also apply to the others)

...
  "dependencies": {
    "formsy-react": "^0.17.0",
    "classnames": "^2.1.3"
  },
  "peerDependencies": {
    "react": "^0.14.0"
  },
...

from formsy-react-components.

pacjin79 avatar pacjin79 commented on May 31, 2024

Just Fyi, I ran into a invalid ref error after upgrading react from 0.14.7 to 15.0.1. Seems this error only happens with pages containing formsy-react and formsy-react-componenents components. I looked into this the recommended gist https://gist.github.com/jimfb/4faa6cbfb1ef476bd105 I'm not doing anything crazy with the refs and definitely do not have multiple copies of react running. My only guess at this point is there's a breaking change either in formsy or formsy-react-components. Switched back to 0.14.7 and all forms are working again. Please let me know if you've ran into anything similar or any recommendations on how to proceed would be great. Really appreciate all the effort you've put into this project, it has become an mission critical piece of my project. thanks a lot!.

from formsy-react-components.

twisty avatar twisty commented on May 31, 2024

Hi @pacjin79, I'm pleased that you're finding this project so useful. Not sure what to suggest at the moment, I'll be making a new release this weekend with react moved to devDependencies, as suggested by @copas2. Maybe wait for that and try again?

I've just rebuilt the playground example using [email protected] and the github master version of formsy-react-components -- it built okay using browserify and seems to be fine.

@franklinkim I've gone ahead and added a peerDependencies hint for react v0.14 or v15. (I think npm version 3 no longer tries to install peer dependencies, it just warns if they're not satisfied).

from formsy-react-components.

pacjin79 avatar pacjin79 commented on May 31, 2024

Ok sounds good thanks again!

from formsy-react-components.

franklinkim avatar franklinkim commented on May 31, 2024

thanks!

from formsy-react-components.

twisty avatar twisty commented on May 31, 2024

Just released v0.7.1 to enable installing React v15.

from formsy-react-components.

pacjin79 avatar pacjin79 commented on May 31, 2024

awesome, trying it now. Thanks a lot @twisty

from formsy-react-components.

pacjin79 avatar pacjin79 commented on May 31, 2024

@twisty I just realized I never reported my findings. upgraded to react 15.0.1, formsy-react-component 0.7.1, and formsy-react 0.18.0. So far everything is working perfectly. Thanks a lot for fixing this

from formsy-react-components.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.