Comments (10)
simonsan
commented on June 7, 2024
1
"Take serde. If one package enables the derive feature then packages that don't need it, like serde_json or toml, can't build until all of the proc-macro machinery is built."
So you could also split out the derive feature and pull in serde_derive extra, as a start.
from twitch_api.
Emilgardis
commented on June 7, 2024
These tests should be done on windows and linux
from twitch_api.
Emilgardis
commented on June 7, 2024
Should try to make a reproducible benchmark to keep track of this, I feel like the compile time has improved with rustc versions
from twitch_api.
Emilgardis
commented on June 7, 2024
❯ summarize summarize --percent-above 10 twitch_api-0025240.mm_profdata
+------------------------------+-----------+-----------------+--------+------------+---------------------------------+
| Item | Self time | % of total time | Time | Item count | Incremental result hashing time |
+------------------------------+-----------+-----------------+--------+------------+---------------------------------+
| LLVM_module_codegen_emit_obj | 59.75s | 53.079 | 59.75s | 256 | 0.00ns |
+------------------------------+-----------+-----------------+--------+------------+---------------------------------+
| LLVM_passes | 15.30s | 13.594 | 15.30s | 1 | 0.00ns |
+------------------------------+-----------+-----------------+--------+------------+---------------------------------+
| codegen_module | 11.34s | 10.076 | 14.73s | 256 | 0.00ns |
+------------------------------+-----------+-----------------+--------+------------+---------------------------------+
Total cpu time: 112.558478793s
Filtered results account for 76.749% of total time.
+----------------------------+-----------------+
| Item | Artifact Size |
+----------------------------+-----------------+
| codegen_unit_size_estimate | 3781590 bytes |
+----------------------------+-----------------+
| crate_metadata | 53295483 bytes |
+----------------------------+-----------------+
| dep_graph | 158831053 bytes |
+----------------------------+-----------------+
| linked_artifact | 323684368 bytes |
+----------------------------+-----------------+
| object_file | 251006424 bytes |
+----------------------------+-----------------+
| query_cache | 93758624 bytes |
+----------------------------+-----------------+
| work_product_index | 14794 bytes |
cargo llvm-lines --all-features
Lines Copies Function name
----- ------ -------------
7150872 136439 (TOTAL)
715551 (10.0%, 10.0%) 17022 (12.5%, 12.5%) core::result::Result<T,E>::map_err
544038 (7.6%, 17.6%) 2349 (1.7%, 14.2%) <serde_json::de::SeqAccess<R> as serde::de::SeqAccess>::next_element_seed
461914 (6.5%, 24.1%) 864 (0.6%, 14.8%) <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_struct
326040 (4.6%, 28.6%) 247 (0.2%, 15.0%) <twitch_api::eventsub::event::_::<impl serde::de::Deserialize for twitch_api::eventsub::event::EventType>::deserialize::__Visitor as serde::de::Visitor>::visit_enum
261818 (3.7%, 32.3%) 2405 (1.8%, 16.8%) <serde_path_to_error::de::MapAccess<X> as serde::de::MapAccess>::next_value_seed
226709 (3.2%, 35.5%) 316 (0.2%, 17.0%) <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_any
213487 (3.0%, 38.5%) 2349 (1.7%, 18.7%) <serde_path_to_error::de::SeqAccess<X> as serde::de::SeqAccess>::next_element_seed
208653 (2.9%, 41.4%) 2496 (1.8%, 20.6%) <serde_path_to_error::de::TrackedSeed<X> as serde::de::DeserializeSeed>::deserialize
196638 (2.7%, 44.1%) 2112 (1.5%, 22.1%) <serde_ignored::MapAccess<X,F> as serde::de::MapAccess>::next_value_seed
156592 (2.2%, 46.3%) 160 (0.1%, 22.2%) <twitch_api::eventsub::_::<impl serde::de::Deserialize for twitch_api::eventsub::EventSubscriptionInformation<E>>::deserialize::__Visitor<E> as serde::de::Visitor>::visit_map
144270 (2.0%, 48.3%) 2403 (1.8%, 24.0%) <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_value_seed
143722 (2.0%, 50.3%) 2053 (1.5%, 25.5%) <serde_ignored::SeqAccess<X,F> as serde::de::SeqAccess>::next_element_seed
128832 (1.8%, 52.1%) 244 (0.2%, 25.7%) <twitch_api::eventsub::_::<impl serde::de::Deserialize for twitch_api::eventsub::Status>::deserialize::__Visitor as serde::de::Visitor>::visit_enum
87906 (1.2%, 53.4%) 289 (0.2%, 25.9%) <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_enum
76217 (1.1%, 54.4%) 364 (0.3%, 26.1%) <serde_json::de::MapAccess<R> as serde::de::MapAccess>::next_key_seed
75925 (1.1%, 55.5%) 1247 (0.9%, 27.1%) serde_path_to_error::de::<impl serde::de::Visitor for serde_path_to_error::wrap::Wrap<X>>::visit_seq
73786 (1.0%, 56.5%) 1212 (0.9%, 27.9%) serde_path_to_error::de::<impl serde::de::Visitor for serde_path_to_error::wrap::Wrap<X>>::visit_map
70721 (1.0%, 57.5%) 864 (0.6%, 28.6%) <serde_path_to_error::de::Deserializer<D> as serde::de::Deserializer>::deserialize_struct
67832 (0.9%, 58.5%) 160 (0.1%, 28.7%) <twitch_api::eventsub::_::<impl serde::de::Deserialize for twitch_api::eventsub::EventSubscriptionInformation<E>>::deserialize::__Visitor<E> as serde::de::Visitor>::visit_seq
61713 (0.9%, 59.3%) 332 (0.2%, 28.9%) <&mut serde_json::de::Deserializer<R> as serde::de::Deserializer>::deserialize_str
45126 (0.6%, 60.0%) 2232 (1.6%, 30.6%) serde_path_to_error::wrap::Wrap<X>::new
41007 (0.6%, 60.5%) 1005 (0.7%, 31.3%) core::result::Result<T,E>::map
A lot of the time comes from llvm, and most of it seems to be serde, I wonder if there's a neat way to avoid this, perhaps making json the only supported serialization/deserialization unless something else is wanted, thus skipping serde
from twitch_api.
Emilgardis
commented on June 7, 2024
Maybe miniserde or serde-lite could help?
miniserde doesn't have all the features we're using currently but serde-lite could maybe be interesting, but doesn't either have all the features we use
from twitch_api.
Emilgardis
commented on June 7, 2024
Removing a single module in helix makes quite a difference, I wonder if there's something bad we're doing that can be fixed by forcing the compiler to not inline or to actually inline
from twitch_api.
Nerixyz
commented on June 7, 2024
Removing a single module in helix makes quite a difference
Maybe modules could be en-/disabled one-by-one? I think it's rarely the case that you need every helix/eventsub/... module.
from twitch_api.
Emilgardis
commented on June 7, 2024
Maybe modules could be en-/disabled one-by-one? I think it's rarely the case that you need every helix/eventsub/... module.
That sounds very easy, could possibly have multiple scopes, and with the new feature where cargo tell you that an item is behind a cfg, quite discoverable
- bits
- channels
- charity
- chat
- client
- clips
- eventsub
- games
- goals
- hypetrain
- moderation
- points
- polls
- predictions
- raids
- request
- response
- request
- schedule
- search
- streams
- subscriptions
- tags
- teams
- users
- videos
- whispers
that's a lot of feature flags though :3
from twitch_api.
Emilgardis
commented on June 7, 2024
the problem is not serde or serde_derive, the problem is the code it generates @simonsan, but we could definitely switch to using serde_derive to make compilation more parallel. Related serde-rs/serde#2584 (comment)
edit: having trouble decoupling serde/derive and serde_derive in twitch_types due to needing serde?/derive
from twitch_api.
Emilgardis
commented on June 7, 2024
cargo build -F all (1 thread) 14s
cargo build -F all (8 threads) 9.7s
from twitch_api.
Related Issues (20)
- Impossible to use requests / body with DeserializeOwned HOT 5
- EventSub Over WebSocket HOT 3
- Why can't I put multiple broadcaster_id in GetChannelInformationRequest? HOT 2
- Games: Get Games and Get Top Games IGDB Field
- Help appreciated (get_followed_streams) HOT 2
- Getting a backtrace with a specific broadcaster id 418158680 HOT 2
- introduce `beta` feature for public betas instead of `unsupported`
- Make `helix::client::custom` first-class
- another bug while decoding teaminfo HOT 4
- Add way to mock responses
- Investigate querying twitch docs HOT 1
- sprinkle more must_use on all structs
- Bors deprecation - remaining
- Clarify how or make it easier to pass in collections that are T: Iterator<Item=D> in builder functions for helix requests HOT 4
- Create a tower rate limiter for helix which respects twitch headers
- use `async fn` and return-position `impl Trait` in trait HOT 1
- Enum twitch_api::eventsub::Status unknown variant `websocket_failed_to_reconnect` HOT 2
- reqwest 0.12 upgraded hyper, http, and http-body to v1, causing build failures
- Update to reqwest 0.12 make error "trait `twitch_api::HttpClient` is not implemented for `reqwest::Client`" HOT 8
- Future incompatibility with Rust RFC 3373: Avoid non-local definitions in functions
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twitch_api.