Comments (5)
You probably are onto something. Gladly will accept a PR that makes the change.
from cloudhopper-smpp.
Pull request added #115
from cloudhopper-smpp.
Hi!
Branch 'netty4' peace of code:
// write the pdu out & wait timeout amount of time
ChannelFuture channelFuture = this.channel.writeAndFlush(buffer);
if (configuration.getWriteTimeout() > 0){
channelFuture.await(configuration.getWriteTimeout());
} else {
channelFuture.await();
}
Method writeAndFlush won't throw exception if channel is closed by other side. So, if 'writeTimeout' is default and session listener doesn't handle 'fireChannelClosed' we'll get the same lock.
Please, let me know if @mthyman PR affects branch netty4?
from cloudhopper-smpp.
@olegagafonov I haven't tried the netty4 branch myself so I haven't seen the problem there, but looking at your code snippet setting a positive write timeout in your config should avoid the problem if it's there.
One a side note, we've been running a special build with my PR in production for almost two months now without seeing any threads get stuck so far.
from cloudhopper-smpp.
@mthyman You're right! Possitive timeout is a solution. But default timeout is a delayed dead-lock.
Your PR and my code snippet is the same code in differrent branches. But I don't know both branches lifecycle and merge strategy. @jjlauer what do you think?
from cloudhopper-smpp.
Related Issues (20)
- Link SmppSession and SmppSessionHandler
- Threads get stuck at DefaultSmppClient.createConnectedChannel HOT 1
- Receiving SmppChannelException while the SMSC is still sending response HOT 2
- Character Coding issue -Special Characters received as "?" HOT 3
- How I should receive multipart messages? HOT 2
- Is it possible to send messages to SMSC using one Smppsession (or a session that lasts long )because binding & unbinding for every single msg has resulted in creating large number of bind requests at SMSC . Due to this load ,SMSC is failing to receive bind requests and we are receiving the error "com.cloudhopper.smpp.type.SmppTimeoutException: Unable to get response within [3000 ms]" HOT 1
- Adding support sumbit_multi operation
- DeliverSmResp is very slow HOT 2
- Send message to a connected client HOT 1
- Sending Delivery Back to connected client later HOT 1
- Problem connecting to operator "Swisscom"(a swiss mobile operator) HOT 1
- .Net Port?
- how to get the src ip from submit_sm HOT 2
- EnquireLink, SmppTimeoutException
- Getting No request found for PDUHeader from JSMPP library
- How to get DLR from SMSC setting error code
- Cloudhopper SMPP Error codes
- Need to know isUCS2 message. We have GSMCharset.canRepresent(str). Similarly do we have it for UCS messages
- Not able to get the full delivery report on the client side including delivery error code.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cloudhopper-smpp.