Remove the unnecessary "() =>" in `def iteratorSeq` from com.twitter.cassovary.util.io.GraphReader about cassovary HOT 8 CLOSED

Maybe the intention was to open the file on call? Have no idea what else could that be.

It is also puzzling that we don't need to close the file.

Read 2nd answer from: http://stackoverflow.com/questions/4458864/whats-the-right-way-to-use-scala-io-source and it turns out that we should actually avoid scala's Source.fromFile()...

from cassovary.

Aha -- not closing the file is definitely a bug that we should fix.

I wouldn't go to the extent to completely avoid io.Source but yes should take care of exceptions

But this will need to be modified too in AdjacencyListGraphReader as this will be evaluated as soon as the class is created:
val (edgesBySource, nodeMaxOutEdgeId) = readEdgesBySource()

from cassovary.

That is true, but () => Iterator is still weird. IMO Iterable looks better than this, if some initialization is needed.

I would like to see there sth like

def iteratorSeq: Iterable[NodeStream]

where

NodeStream extends Iterable[NodeIdEdgesMaxId] with Closeable {..}

from cassovary.

Agreed Iterable is good.

from cassovary.

I'm working on this. I did as @szymonm said. Then, do I also have to change
Seq[() => Iterator[NodeIdEdgesMaxId]] to Iterable[NodeStream] ?

from cassovary.

Sorry. I mean, do I have to change Seq[() => Iterator[NodeIdEdgesMaxId]] to Iterable[NodeStream] in ArrayBasedDirectedGraph and SharedArrayBasedDirectedGraph ?

from cassovary.

Pls squash the commits, @AnishShah when this will be ready to merge.

from cassovary.

@szymonm Done.

from cassovary.