Comments (5)
I don't know what is wp-emoji-release.min.js
file so I gonna mark this as invalid unless I understand what has this library to do with that.
from twemoji.
@WebReflection - sorry for not clarifying that in the initial report. It is simply a bundle of the twemoji.min.js which is being included in the next WordPress 4.2 core release.
The error is being triggered by an undefined node being passed to here:
https://github.com/twitter/twemoji/blob/gh-pages/twemoji.js#L271
My initial thought would be to do a check of the node being undefined and bailing out of that function if that is the case. I can submit a patch if this sounds reasonable.
from twemoji.
nope, I want to know why that's the case.
I need the exact version of the bundled twemoji.min.js
file, hoping that's the latest ( reason there is a CDN ;-) ) and I want the page r document that fails.
I need to know if it fails only in IE9 and eventually why. Having a weak logic in place is not an option, and there should never be a case where subnode is undefined.
I don't want a work around but eventually a proper fix 'casue this library has been battle tested already a lot, nobody mentioned this problem before.
Thanks for collaboration
from twemoji.
http://driving.wpdstg1.canada.com/wp-includes/js/wp-emoji-release.min.js?ver=4.2-beta3-31943
Unminified: http://driving.wpdstg1.canada.com/wp-includes/js/wp-emoji.js
Bundled twemoji.js
: http://driving.wpdstg1.canada.com/wp-includes/js/twemoji.js
from twemoji.
OK this is not really helping.
- that code is for IE8, I don't see a DOMContentLoaded fallback for modern browsers and IE9
- that code trusts readyState and invokes
load
believing that if theemoji
library is in, then thedocument.body
must be in too ... very weird logic in there ... - I've no idea which version of twemoji you are running there. Can you ensure me that's the last one?
- I've no idea against which page that thing is loaded
- I still don't know if it's an IE9 problem only
I won't comment other things that make little sense to me, like new wpEmoji()
without a this
or a prototoype in the entire file, but in order to accept this bug I need a way to understand what's the problem and reproduce. Thanks
from twemoji.
Related Issues (20)
- Emoji of the Brazilian flag is not as consistent as that of the flag of the United States. HOT 4
- bring back twemoji to mobile devices
- FEAT: Improve the ui of footer in the website
- FEAT: Improve the ui of footer in the websit HOT 1
- Fluent Emoji: Twemoji drop-in replacement HOT 3
- about using twemoji HOT 1
- New CDN doesn't seem to work HOT 2
- CDN not needed HOT 1
- Where is the donkey, goose, jellyfish and moose? HOT 10
- How to use twemoji for input field HOT 2
- Grey heart emoji (1FA76.svg) is barely differentiable from the white heart emoji (1F90D.svg)
- Update flag of Martinique HOT 2
- Attribution
- I want to make a Chinese translation HOT 3
- Blue heart (1f499) is different shade than other blue emojis such as blue square, circle, etc. HOT 2
- ![sweating-nervous](https://user-images.githubusercontent.com/2575182/211350030-249c6b1f-a347-4ade-bd40-1ed83629f09f.gif) HOT 1
- Old Twitter Logo (the bird) still not updated (to the X) in twitter.com/account/access HOT 2
- twemoji website doesnt work HOT 2
- CDN links to maxcdn.com are broken HOT 3
- Question: Commercial offline & online usage
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from twemoji.