Giter VIP home page Giter VIP logo

Comments (5)

WebReflection avatar WebReflection commented on May 22, 2024

I don't know what is wp-emoji-release.min.js file so I gonna mark this as invalid unless I understand what has this library to do with that.

from twemoji.

mkaz avatar mkaz commented on May 22, 2024

@WebReflection - sorry for not clarifying that in the initial report. It is simply a bundle of the twemoji.min.js which is being included in the next WordPress 4.2 core release.

The error is being triggered by an undefined node being passed to here:
https://github.com/twitter/twemoji/blob/gh-pages/twemoji.js#L271

My initial thought would be to do a check of the node being undefined and bailing out of that function if that is the case. I can submit a patch if this sounds reasonable.

from twemoji.

WebReflection avatar WebReflection commented on May 22, 2024

nope, I want to know why that's the case.

I need the exact version of the bundled twemoji.min.js file, hoping that's the latest ( reason there is a CDN ;-) ) and I want the page r document that fails.

I need to know if it fails only in IE9 and eventually why. Having a weak logic in place is not an option, and there should never be a case where subnode is undefined.

I don't want a work around but eventually a proper fix 'casue this library has been battle tested already a lot, nobody mentioned this problem before.

Thanks for collaboration

from twemoji.

pathawks avatar pathawks commented on May 22, 2024

http://driving.wpdstg1.canada.com/wp-includes/js/wp-emoji-release.min.js?ver=4.2-beta3-31943

Unminified: http://driving.wpdstg1.canada.com/wp-includes/js/wp-emoji.js

Bundled twemoji.js: http://driving.wpdstg1.canada.com/wp-includes/js/twemoji.js

from twemoji.

WebReflection avatar WebReflection commented on May 22, 2024

OK this is not really helping.

  • that code is for IE8, I don't see a DOMContentLoaded fallback for modern browsers and IE9
  • that code trusts readyState and invokes load believing that if the emoji library is in, then the document.body must be in too ... very weird logic in there ...
  • I've no idea which version of twemoji you are running there. Can you ensure me that's the last one?
  • I've no idea against which page that thing is loaded
  • I still don't know if it's an IE9 problem only

I won't comment other things that make little sense to me, like new wpEmoji() without a this or a prototoype in the entire file, but in order to accept this bug I need a way to understand what's the problem and reproduce. Thanks

from twemoji.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.