Giter VIP home page Giter VIP logo

Comments (12)

twskj avatar twskj commented on June 26, 2024 1

I have the search functionality in place. I'll polish it a bit before checking with you :-)

from pretty-swag.

Maaartinus avatar Maaartinus commented on June 26, 2024 1

You've also changes the search to require the full quoted tag, which is much better for me, as I have quite a few tags like XYZ and XYZ_ITEM. Fantastic!

The possibility to remove a tag by clicking is nice, too!

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

You can exclude tags by using - prefix. For example, if we want all customer but not with DELETE method, we would type customer -DELETE

Is this something you are looking for?

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

Come to think about it, intersection has its place too. Maybe we could have a flag that can choose between OR or AND

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

I decided to do "doubleQuote" instead of +
The behavior will be

  • the search will return only documents that contain search term in double quotaiton
  • clicking at tag will default to double quotation

from pretty-swag.

Maaartinus avatar Maaartinus commented on June 26, 2024

I proposed + because it's what Google search did some long time ago, but I can live with double quote equally well. 😆 I'm glad about it being the new default.

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

Rolled out!
Check it out and let me know.

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

Just to sum it up for my future reference

The behavior of the filtering is as follow:

  • Using -tag to remove api that contain that particular tag
  • Surrounding tag with double quotation "tag" to narrow down to only api that contains the tag
  • Typing in normally is a blanket search which will match anything that start with that tag

from pretty-swag.

Maaartinus avatar Maaartinus commented on June 26, 2024

There's one more thing.... the list shows really the available tags only, i.e., it changes all the time, which makes it much less practical. Always showing the full list and disabling the unavailable tags would be IMHO much better. Do you like the idea?

If so, then the styling should be so that disabling a tag does not change it's width; otherwise, the following would would move, which is ugly.

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

hmm I like your idea actually. Since now we color them blue, we can easily grey them instead of removing 🤔

Can you justify further or give some use cases why is it much better?

from pretty-swag.

Maaartinus avatar Maaartinus commented on June 26, 2024

Assuming, the tag list is not too huge (my tags are just two lines as I'm using "autoTags": false), it's much better.

  • After adding a wrong tag, I can click again on the same position to remove it.
  • I can find the tag much faster as it's always on the same position.
  • I don't waste time with searching a tag, which isn't there.

from pretty-swag.

twskj avatar twskj commented on June 26, 2024

previously added

from pretty-swag.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.