Hey there! I would like to improve documentation and feedback of the

It may have to be something in this direction: <div class="highlight highlight-sou

looks good! strange all en_us , <cod

Or maybe something like this after all: <div class="highlight highlight-source-pyt

Improve `language()` support / implementation about drawbot HOT 8 CLOSED

roberto-arista commented on August 12, 2024

Improve `language()` support / implementation

from drawbot.

Comments (8)

justvanrossum commented on August 12, 2024 1

A warning sounds useful. Are these strings case sensitive or not? If not: make sure to take that into account when checking.

from drawbot.

typemytype commented on August 12, 2024

for now there is already a warning when a language is set which is not available: *** DrawBot warning: Language 'foo' has no hyphenation available. *** (only while drawing text)

language("foo")
hyphenation(True)
text("bar", (10, 10))

a check is maybe a bit more complex then just looking if the language tag is in that list, fe: nl-be or fr-CA, this is the full spec: language-extlang-script-region-variant-extension-privateuse see

so language() could draw some dummy text somewhere that produce this warning..

from drawbot.

typemytype commented on August 12, 2024

had to look it up, this could be added while setting language:

drawbot/drawBot/drawBotDrawingTools.py

Line 1519 in 6697d56

def _checkLanguageHyphenation(self):

from drawbot.

justvanrossum commented on August 12, 2024

had to look it up, this could be added while setting language:

But that checks whether there is hyphenation for that language, which may be distinct from "we have a valid language".

from drawbot.

typemytype commented on August 12, 2024

this list all possible options for language(..)

import AppKit
print(AppKit.NSLocale.availableLocaleIdentifiers())

from drawbot.

justvanrossum commented on August 12, 2024

It may have to be something in this direction:

import AppKit

def isLanguageCodeOk(langCode):
    parsedLoc = AppKit.NSLocale.componentsFromLocaleIdentifier_(langCode)
    lang = parsedLoc[AppKit.kCFLocaleLanguageCodeKey]
    country = parsedLoc.get(AppKit.kCFLocaleCountryCodeKey)
    return lang in AppKit.NSLocale.ISOLanguageCodes() and (
        country is None or country in AppKit.NSLocale.ISOCountryCodes()
    )

for langCode in ["ab", "abk", "abz", "AB", "en-us", "en_us", "EN-US", "en-zz"]:
    print(langCode, isLanguageCodeOk(langCode))

Output:

ab True
abk True
abz False
AB True
en-us True
en_us True
EN-US True
en-zz False

from drawbot.

typemytype commented on August 12, 2024

looks good!

strange all en_us, en-us and EN-US are valid

from drawbot.

justvanrossum commented on August 12, 2024

Or maybe something like this after all:

import AppKit


def canonicalLocaleCode(localeCode):
    parsedLoc = AppKit.NSLocale.componentsFromLocaleIdentifier_(localeCode)
    parts = [
        parsedLoc[AppKit.kCFLocaleLanguageCode],
        parsedLoc.get(AppKit.kCFLocaleScriptCode),
        parsedLoc.get(AppKit.kCFLocaleCountryCode),
    ]
    return "_".join(part for part in parts if part)


def isLanguageCodeOk(localeCode):
    localeCode = canonicalLocaleCode(localeCode)
    return localeCode in AppKit.NSLocale.availableLocaleIdentifiers()


for langCode in [
    "ab",
    "abk",
    "abz",
    "AB",
    "en-us",
    "en_us",
    "EN-US",
    "en-zz",
    "sr-cyrl-me",
    "en",
]:
    print(langCode, isLanguageCodeOk(langCode))

Output:

ab False
abk False
abz False
AB False
en-us True
en_us True
EN-US True
en-zz False
sr_Cyrl_ME True
en True

from drawbot.

Improve `language()` support / implementation about drawbot HOT 8 CLOSED

Comments (8)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent