[Improvement/Addition] Extracting and composing types using $ElementProps about react HOT 6 CLOSED

yes - am very busy this week so will come back and review this next week. thanks!

from react.

Hi,

Is $ElementProps still relevant ?
Isn't React.ComponentProps doing the same job ?

Thanks

from react.

This is very interesting and very appreciated, thank you! can I just ask a clarifying question - in your import Paper from '@material-ui/core/Paper'; example, does that work even if Paper is untyped?

or are you basically saying, ok, @material-ui/core/Paper doesn't export Paper's proptypes, but that's ok, because I can just use $ElementProps to grab it and do manipulations like & and Omit?

Just trying to explain back to you what i think this does. do i have the right idea?

from react.

Yeah thats about right!
Its a nice solution to when you say "I want this prop (eg paperProps) or these props to spread to this component, but not have to decide on the type (be explicit)".
The less explicit about types you are, the safer it will be (imo). Especially when there are any's flying around.

If Paper doesn't have a type because its referencing a JS file (it does though - from material-ui) then TS treats them as any, so yeah it'l work, like everything does with any haha.

It just lets you be a bit more expressive, less explicit, and helps in other situations too, especially with making HOCs - when Component or Props types are generic.
Eg - making recompose's defaultProps work properly with TS (we can't preserve currying though, cause no higher kinded types in TS)

import * as Recompose from 'recompose'
export const defaultProps = <
  C extends React.ComponentType,
  D extends Partial<$ElementProps<C>>
>(
  defaults: D,
  Component: C
): React.ComponentType<$ElementProps<C> & Partial<D>> =>
  Recompose.defaultProps(defaults)(Component);

Make sense?

from react.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

from react.

included in #272

from react.