Giter VIP home page Giter VIP logo

Comments (12)

infctr avatar infctr commented on March 29, 2024 8

I guess it goes like

type ComponentProps<T> = T extends React.ComponentType<infer P> | React.Component<infer P>
  ? JSX.LibraryManagedAttributes<T, P>
  : never;

interface IProps {
  name: string;
}

interface IDefaultProps {
  age: number;
}

const GreetComponent = ({ name, age }: IProps & IDefaultProps) => (
  <div>{`Hello, my name is ${name}, ${age}`}</div>
);

const defaultProps: IDefaultProps = {
  age: 25,
};

GreetComponent.defaultProps = defaultProps;

// later

const TestComponent = (props: ComponentProps<typeof GreetComponent>) => {
  return (
    <div> <h1 /> </div>
  );
};

const el = <TestComponent name="foo" />;

from react.

infctr avatar infctr commented on March 29, 2024 2

@sw-yx My point is (and that's my understanding of @gausie problem)

type Props = React.ComponentProps(typeof GreetComponent) // all props are required

type Props = ComponentProps<typeof GreetComponent> // using helper, defaulted props are optional

Extracting props with JSX.LibraryManagedAttributes is more in line with the old practice marking default props as optional on an interface like interface Props extends Partial<DefaultProps> { /* ... */ } and using it later.

Consdider this

interface Props extends ComponentProps<typeof GreetComponent> {
  title: string;
}

const TestComponent = ({ title, ...props }: Props) => {
  return (
    <>
      <h1>{title}</h1>
      <GreetComponent {...props} />
    </>
  );
};

// age is optional on an inner component's props interface
const el = <TestComponent name="Johnny 5" title="foo" />; 

Just thought it was worth mentioning as it was not immediately obvious

from react.

swyxio avatar swyxio commented on March 29, 2024

ok what do you recommend i put in the cheatsheet?

from react.

gausie avatar gausie commented on March 29, 2024

from react.

swyxio avatar swyxio commented on March 29, 2024

have you reported this as a bug? (is this a bug? i think it is?)

from react.

gausie avatar gausie commented on March 29, 2024

from react.

swyxio avatar swyxio commented on March 29, 2024

just try :) good luck

from react.

ferdaber avatar ferdaber commented on March 29, 2024

Do you have a code example for this? I would also open this as an issue in the DefinitelyTyped repo instead so the other React types maintainers can take a look.

from react.

swyxio avatar swyxio commented on March 29, 2024

thanks for the input @infctr! i dont quite see the point of TestComponent.

  • if i replace your impl of ComponentProps with the official one React.ComponentProps, i see that TestComponent errors because of the missing age default prop.
  • if i then add TestComponent.defaultProps = defaultProps; it typechecks.

this seems correct behavior.

@gausie, can we please see an example that you expect to work? otherwise its very hard to discuss.

from react.

ferdaber avatar ferdaber commented on March 29, 2024

That's correct. There are valid use cases for extracting both the inner props of a component, or the apparent props (with JSX.LibraryManagedAttributes). The built-in React types only take care of the first case.

from react.

swyxio avatar swyxio commented on March 29, 2024

hoo boy. ok. thank you

from react.

stale avatar stale commented on March 29, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions!

from react.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.