Comments (3)
Josh-Cena
commented on June 3, 2024
1
I'm not big about this. As you realized it's not ES standard and not every runtime has it. We have never prioritized a web feature before. I also think there's no instance method at play here so the chance of false-positives with a purely syntactic rule is low.
from typescript-eslint.
Josh-Cena
commented on June 3, 2024
1
If you want to detect multi-level objects and report them being shallowly cloned, I'm totally fine, but the rule should just be called no-partial-clone or something. On the other hand I don't think JSON round-tripping is bad for simple cases.
from typescript-eslint.
kirkwaiblinger
commented on June 3, 2024
For fun, an example of code in the typescript-eslint repo that would flag:
typescript-eslint/packages/eslint-plugin/src/util/getFunctionHeadLoc.ts
Lines 199 to 202 in f813147
from typescript-eslint.
Related Issues (20)
- Docs: Consider explicitly mentioning rule report properties as not covered by semver HOT 1
- Enhancement: [no-unnecessary-condition] Check truthiness assertion functions
- Configs: Apply changes to config presets for v8
- Enhancement: [prefer-nullish-coalescing] should ignore Boolean constructor HOT 4
- Repo: Use ESLint v9 for our internal linting HOT 3
- feat(eslint-plugin): remove deprecated no-throw-literal rule
- Docs: Updated typed linting docs for new project service
- Bug: incorrect peer dependencies in v8.0.0-alpha.10 packages HOT 6
- Parser: remove EXPERIMENTAL_useSourceOfProjectReferenceRedirect in favor of project service HOT 1
- Repo: publishing v8 canary versions failed - "Not Found - PUT https://registry.npmjs.org/@typescript-eslint/types - Not found" HOT 2
- Bug: Broken examples? HOT 1
- Docs: Quickstart guide should be clear on type: module not being a requirement HOT 6
- Repo: Failing to publish new alpha versions of v8 post-v8.0.0-alpha.10 HOT 2
- Bug: [v8.0.0-alpha.10] incorrect error message `Parsing error: "parserOptions.programs"` HOT 1
- Bug: [member-ordering] Not Detecting Order For Read-Only Fields Correctly HOT 1
- Bug: Default configuration following https://typescript-eslint.io/getting-started results in error HOT 1
- Bug(typescript-estree): always parse mts/mjs as ESM for non-type-aware parsing HOT 6
- Docs: Write blog post on the history of ban-types, {}, and object/Object
- Bug: [no-unnecessary-boolean-literal-compare] False positive and unsafe fix with exactOptionalPropertyTypes HOT 6
- no-unsafe-call: ban calling Function HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript-eslint.