Comments (3)
That is, when
if (promise)
was in fact intended.
This makes sense only when promise
is nullable. And that case is currently handled by the rule. In the example below, if (maybePromise)
is not reported:
declare const maybePromise: Promise<void> | undefined
if (maybePromise) { }
// ^?
declare const promise: Promise<void>
if (promise) { }
// ^?
Could you provide an example where the if (promise)
required for non-nullable promise
?
from typescript-eslint.
On looser typescript settings, the nullable bit isn't required for it to be nullable. I am ok with adding the nullable type being an example of how to fix the issue, even though that makes the case of Promise<boolen> | undefined
unclear on whether the if is meant to be for the value or the promise. The rule works as intended; this suggestion is just for adding explicit examples/guidance to users for how to handle that use case without using eslint-disable.
from typescript-eslint.
On looser typescript settings
In general we don't support "looser" settings and assume you have at least strictNullChecks
turned on. Because if you don't have it turned on then your code is provably unsound. Because turning it on is the industry baseline.
Our rules are powered by the types - so if your types are unsound then the rules are in an undefined state. It's usually impossible for us to report "correctly" because things like null
can be removed from unions.
How can we possibly understand your code if your types are incorrect?
from typescript-eslint.
Related Issues (20)
- Bug(typescript-estree): Project services not working with (tsconfig) extends, project references, and extraFileExtensions HOT 4
- Bug: [no-unnecessary-type-assertion] Conflict with TS for variables used before assignment HOT 5
- Docs: Move PR-specific testing advice from Contributing > Local Development to Pull Requests
- Rule proposal: Consider bringing back no-duplicate-imports HOT 1
- Website: Rules sidebar missing from "tombstone" pages HOT 5
- Bug: [no-redundant-type-constituents] Differentiate a types-error any from a "true" any
- Bug: [no-unsafe-argument] Differentiate a types-error any from a "true" any
- Bug: [no-unsafe-call] Differentiate a types-error any from a "true" any
- Bug: [no-unsafe-member-access] Differentiate a types-error any from a "true" any
- Bug: [no-unsafe-return] Differentiate a types-error any from a "true" any
- AST tightening: `TSDeclareFunction` has no body, `declare function` cannot have `async` or `*` HOT 1
- AST tightening: `TSExternalModuleReference#expression` must be a `StringLiteral` HOT 1
- AST tightening: around init/definite combinations on let/var/const declarators HOT 1
- AST tightening: `PrivateIdentifier` can only be LHS of `BinaryExpression[operator='in']` HOT 1
- Bug: rc-v8 projectService option leads to default project errors when used with eslint-plugin-import
- Bug: Missing peer dependencies HOT 8
- Bug: [ast-spec] wrong type for callee of CallExpression, NewExpression, TaggedTemplateExpression
- Bug: [no-duplicate-type-constituent] fixer removes undefined from type HOT 7
- Enhancement: [no-floating-promises] foreach of async callbacks HOT 1
- Repo(integration-tests): Vue integration tests need modernization HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from typescript-eslint.