Create TaskCompletionSource with TaskCreationOptions.RunContinuationsAsynchronously about cliwrap HOT 5 CLOSED

Are you sure? I can see it's available in .NET Standard 2.0. It's only .NET Framework where it's not supported before 4.6 (but we don't target it anyway).

from cliwrap.

Hi, I had no idea about this. Sounds like a terrible design oversight to me, I would have never considered that to be the default behavior.

If you want, you're welcome to submit a PR to fix this.

from cliwrap.

I guess (but really don't know) that's due to other defaults when the TCS is creating the Task itself and those make more sense in other cases (i.e. forcing async execution might have some overhead I guess). Probably they noticed the downsides of this default after releasing the API. When setting up a PR I noticed that the option is actually unavailable in NS2.0 (but available in all the other relevant targets). Thus, afaik this is only fixable for the other targets using a compiler condition. Looking further into it this seems to be only relevant for this one use of the TCS.

Now, how WhenAll is implemented and thus if this is relevant is beyond my knowledge. I'll still send the PR for reference (#55) but I'm currently not sure what's the right way to proceed. On one hand, not doing this makes possible future usages of the TCS's task kind of dangerous and would lead to hard to debug situations then. On the other hand merging fixes this for some platforms but keeps others (possibly in the future) broken.

from cliwrap.

Hmm, seems like you're right. Strange. IntelliSense first told me it wouldn't be available, but doesn't tell me anymore now. It compiles fine too. A small test class lib project targeting only NS2.0 plus a unit test using it executes fine too. This supports it too. I'll change the PR. Strange enough, I really don't know how this happened.

from cliwrap.

No worries ;)

from cliwrap.