Stdin piping doesn't work with a stream that never resolves about cliwrap HOT 8 CLOSED

I reproduced this, looks like there are two issues:

1. When copying stdin from a stream, the data is not flushed at earliest opportunity.
2. When the underlying command finishes before stdin is fully read (in this case Console.OpenStandardInput() is not closed during command's lifetime and is technically infinite) then the execution deadlocks

I'm working on a fix now.

from cliwrap.

@Tyrrrz yes, tested this with 3.1.0 in the repro project I set up, and it works perfectly now. Thanks for the speedy fix! 👍

from cliwrap.

Does it work if you insert the end-of-input character (^z aka ctrl+z)?

from cliwrap.

It definitely changes something, but I can't make sense of exactly what's happening. It's like, nothing happens until I send ^Z + Enter (just ^Z does nothing) and at that point it looks a bit like git.exe processes all the input.

Looks like this:

First the prompt shows, then I type a + Enter + n + Enter, then ^Z + Enter and then git.exe exits with exit code 1.

Does it tell you anything?

from cliwrap.

I created a simple repo to help with reproduction: https://github.com/paynecrl97/FileMergeConflicts

1. Clone the repo, and checkout the master branch.
2. Use Git to merge the mergeMeIntoMaster branch into master. You'll encounter conflicts, this is expected.
3. Run the program at the top of this thread (you'll need to change the working directory to the directory that you cloned the repo to)

from cliwrap.

Thanks for the repro, I'll check it when I have a bit more time.

from cliwrap.

Released a fix.

from cliwrap.

@DaRosenberg curious if you've tried the new version already and it works as you expect.

from cliwrap.