ExpressionAttributeNames/Values can include hyphens about electrodb HOT 5 CLOSED

Hi @metuuu 👋

First of all, how dare you.

Second of all, this is a good find.

In most cases the library strives limit the surface area of the validation and constraints it adds. This is typically because DynamoDB changes their own limits and constraints all the time, so it wouldn't be right for the library to try match/duplicate those.

I'll note this change see about improving the formatting of these expression attributes/names 👍

Does DynamoDB even allow for spaces in their field names? I've never tried.

from electrodb.

My example was a bit over the top I agree 😄 I'm sure you don't have to worry about spaces.

Thank you!

from electrodb.

Just to note that in my actual case I was storing images to an object and the image IDs were generated with nanoid which can include hyphens and underscore. UUIDs would also have the same issue.

images: {
  // { <image-id>: <s3-key> }
  type: CustomAttributeType<{ [imageId: string]: string }>>('any'),
}

from electrodb.

I just published the fix with 2.10.6. You can use the same playground link you created to see the change in action

We can close this ticket when you've verified your use case 👍

from electrodb.

All seems good! I agree with your solution, that if someone wants to shoot themselves in the leg by trying to store two items like test-item & testitem to same map its completely their own fault.

Thank you 🙏🏻

from electrodb.