Giter VIP home page Giter VIP logo

Comments (7)

Tzahi12345 avatar Tzahi12345 commented on May 20, 2024 1

possible for progress bar to show up on other devices?

This is a good idea, but it will require a refactor of the way current downloads are managed. Right now it's all done in the UI, but for other devices to get that information the backend needs to be doing most of the legwork. This would be a great change actually, as it would give the backend more freedom on managing active downloads (making cancelling downloads actually possible, developing a possible queuing system)

I'll include this in the next update, thanks for the suggestion!

from youtubedl-material.

nebula-it avatar nebula-it commented on May 20, 2024 1

That looks great!. Good job @Tzahi12345 .
Looking forward to further enhancements with audio and playlist downloads.
Cheers

from youtubedl-material.

Tzahi12345 avatar Tzahi12345 commented on May 20, 2024

Glad you're enjoying it! :)

The indeterminate progress bar is intentional, but it wasn't always that way. I decided to make it so many versions ago because I had a hard time actually determining the progress on the file.

Basically, the client periodically asked the server to check on the file size of the downloading mp3/mp4 and compare it to the expected file size. It worked in most cases, but sometimes the file would split into parts or be in an entirely different format before being converted. So I gave up on the half-solution, and haven't revisited it since then.

But I was thinking about this recently, and it is something I'd like to implement sometime soon, as it would provide essential information to users. I'm sure there will be a lot of edge cases, so maybe have the indeterminate mode be a fallback in case the server can't determine the actual progress.

I'll put this up as a feature to add for the next update, v4.0. Still deciding which features I want for that update, so it might be some time until it gets implemented. Btw, you're in the right place for suggestions/questions, so feel free to open up any more issues if you encounter anything else or want to recommend a feature. They are always appreciated!

from youtubedl-material.

mjpmme avatar mjpmme commented on May 20, 2024

Great explanation for me. Thank you.

from youtubedl-material.

nebula-it avatar nebula-it commented on May 20, 2024

Just to add on to this, possible for progress bar to show up on other devices? E.g I start the download from my phone and opening up ytdl on my PC currently does not show currently downloading files/progress bar. It would be ideal if its possible to check from other devices as well.
Cheers

from youtubedl-material.

Tzahi12345 avatar Tzahi12345 commented on May 20, 2024

Just leaving a comment to let you know functional download progress bars has been implemented! It isn't enabled for audio files as the download speeds appeared significantly slower, but I will investigate this more and may make the downloading method configurable. Thanks @mjpmme for the suggestion!

@nebula-it your idea for viewing downloads across other devices is implemented as well. There's a new downloads manager that has been added where you can view all of this. It isn't organized in the prettiest way now so that will be worked on until it gets released in 4.0. Thank you for recommending this feature!

You can view the relevant pull request here for more info and a sneak peek of the downloads manager.

from youtubedl-material.

mjpmme avatar mjpmme commented on May 20, 2024

Thanks @Tzahi12345 that’s awesome!

from youtubedl-material.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.