Giter VIP home page Giter VIP logo

Comments (13)

mkr-plse avatar mkr-plse commented on May 11, 2024 2

Great idea. We can do two things here:
a) By default, we will print the summary of what happened as part of the refactoring.
b) Optionally, if the user specifies an option, we can log the activity of the refactoring process at the appropriate granularity.

The latter will be more expensive but will only be used for debugging the process of refactoring.

from piranha.

ketkarameya avatar ketkarameya commented on May 11, 2024 1

Oh yea ! My plan is to do it much much sooner. This is also an internal requirement so ...

from piranha.

manishamishra2715 avatar manishamishra2715 commented on May 11, 2024

hii..I am trying to integrate piranha using maven.Also I have configured all the required jar files inside pom.xml file.Also the maven test result is getting successful.But where can I get the expected output??
I m not able to analyse where the output is generated.Please help me with this

from piranha.

mkr-plse avatar mkr-plse commented on May 11, 2024

When you build it with the given options in the instruction, the refactoring should happen in place and whatever you provided as source must have been updated.

from piranha.

manishamishra2715 avatar manishamishra2715 commented on May 11, 2024

Thanks for quick response...actually the source is not getting updated. I am running by project->Run As->maven test.Also tried with pom.xml->Run As->maven test.Is this the correct approach?
can you please guide me , which one to run?

from piranha.

manishamishra2715 avatar manishamishra2715 commented on May 11, 2024

Almost reached the solution referring the previous solutions to the issue raised

from piranha.

msridhar avatar msridhar commented on May 11, 2024

Glad it’s almost working! Two tips for the future:

  1. If you’re having a problem with Piranha, please either open a new issue or comment on an issue reflecting the same problem. This issue is about something different.

  2. If you’re having a build system integration problem, please provide output from running on the command line. Unfortunately we don’t have time to support IDE integrations at the moment.

from piranha.

manishamishra2715 avatar manishamishra2715 commented on May 11, 2024

yes sure...thanks for info :)

from piranha.

pranavsb avatar pranavsb commented on May 11, 2024

It would also be helpful to output "near misses" during execution.
Makes it easier to identify if the returnType or receiverType is slightly off, for instance. Or if the properties file path was specified incorrectly.

Does it make sense to log these in an optionally specified file or would that be too much overhead?

from piranha.

j1nma avatar j1nma commented on May 11, 2024

Could this also work independently from the in-place removals?

That is, run Piranha and only get this summary, and don't modify any files.

from piranha.

ketkarameya avatar ketkarameya commented on May 11, 2024

Yes. Polyglot Piranha allows one to express match-only rules (That change is under PR now) . So we can get this summary without replacements too.

from piranha.

j1nma avatar j1nma commented on May 11, 2024

❤️. Can we expect this sometime this year?

from piranha.

ketkarameya avatar ketkarameya commented on May 11, 2024

@j1nma I have added the functionality you requested for. Can you try now?

Basically you have to create match-only rules for your feature flag API.
So u can build upon stale_feature_flag_cleanup_demos and match_only_demos.
Tip: You can convert the stale_feature_flag_cleanup_demos to just return you the matches (Without rewriting the code) by deleting the rules.replace and rules.replace_node.

from piranha.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.