Go comments not being cleaned up correctly about piranha HOT 4 CLOSED

Hey @ketkarameya apologies I just got a chance to look back at this, that pr looks good and solves the cases I'd spotted. Thanks!

from piranha.

Hey! Thanks a lot for reporting this.
the go cleanup mechanism we have is pretty much experimental :| We have not battle tested it yet (by running it on our internal codebase) But thanks for doing this :) I will look into it. Like our java/kotlin cleanup is kinda robust.
cc @dvmarcilio

from piranha.

thanks for pinging me, @ketkarameya.

Thanks for the detailed report, @conormurray95!
It nicely outlines the comments-cleanup inconsistencies I saw when experimenting with the Go rules.

I'll try to look closer into this in the upcoming days. Hopefully, I can pinpoint a cause.

from piranha.

@conormurray95 can you check this branch go_comment_bug #392 on your go codebase, and let me know if it works as expected?

from piranha.