Provider corrupting documents when updates applied after loading from indexeddb about hocuspocus HOT 9 CLOSED

@tommoor thanks for the heads up, will give it a go.

Ive seen some interesting things coming to the provider like random reconnect intervals that I am keen on. 🤞

from hocuspocus.

@ValentaTomas @tommoor this is still an issue. I made a video of the difference between the two providers in my application. I know it isn't enough to debug the issue just wanted to show that there is a difference still at least:

If I had to guess I think its to do with setting nested Y.Map/Y.Array as my data structure looks something like:

Y.Map {
   items: Y.Map {
       '123': Y.Map {
           itemProps: Y.Map {
               matrix: Y.Array []
           }
        }
   }
}

Replacing this matrix above with a new Y.Array is what is happening in the video and with the @hocuspocus/provider the matrix is deleted, with y-websocket the update happens correctly.

This only appears to happen when I load the documents out of indexeddb first (why I had to leave the document and re-enter for the video above).

from hocuspocus.

Thank you for the video, this is very helpful. We've been discussing some extra tooling to make debugging this type of situation a little easier, but to me this is one of the most critical bugs on the list right now – it might be indicative of deeper sync problems.

from hocuspocus.

You might want to give this another try, up until hocuspocus/[email protected] the server was initiating the sync protocol rather than the client – this could have had some odd effects.

from hocuspocus.

I just tried it yesterday and I think the problem is still there. Any success @georeith ?

from hocuspocus.

Thanks for the bug report!

Just for reference, I’ll follow-up here with more ideas to improve the debugging: #187

I’ve just compared the relevant code for handling document updates in y-websocket and the @hocuspocus/provider and couldn’t see any issue.

Will dig deeper. ⛏️

from hocuspocus.

I think we fixed it. Would you mind to test again with @hocuspocus/[email protected] @georeith?

from hocuspocus.

@hanspagel I haven't had a chance to test with the latest @hocuspocus/server but I've just tried @hocuspocus/[email protected] and it appears the issue is now fixed 😀

from hocuspocus.

Going to close this as resolved, please reopen if need be.

from hocuspocus.