Comments (5)
hmm yep we're still lacking documentation for this unfortunately. It's intended behavior as the socket can be created without a document connected/connecting (and should survive a document being destroyed as you can just open another one)
If you want to close the connection, you need to destroy the websocket provider as well (socket.disconnect() or socket.destroy()
). Documentation is in the process ..
from hocuspocus.
Closing this, as the behaviour is intended. The memory leak has already been fixed by @raineorshine :)
from hocuspocus.
+1 I've been meaning to make a ticket about this, I'm manually destroying the websocket provider at the same time in our application.
from hocuspocus.
I think the problem in here.
#637
from hocuspocus.
I agree with the intended behavior described above but I noticed something else that seems unexpected.
I'm reusing single HocuspocusProviderWebsocket
across multiple HocuspocusProvider
instances and then manually destroy these when required (onBeforeUnmount
hook in Vue). But it seems that provider doesn't unsubscribe properly from websocketProvider
which leads to a memory leak.
For example, onStatus
hook will still be called for websocket reconnect events later even after HocuspocusProvider
has been explicitly destroyed.
Here handler is configured, but this.removeAllListeners()
in destroy call won't unsubscribe this.
Will try to provide a minimal repro soon.
from hocuspocus.
Related Issues (20)
- Hocuspocus >=2.7.0 does not work with React in strict mode / Lexical HOT 5
- Support logging request/socket information in custom Logger.log function HOT 1
- Unsure how to fallback gracefully from initial provider connection issues HOT 2
- Migrate from slate js to prosemirror HOT 1
- Unnecessary onStoreDocumentHooks call on last connection close (potential data loss) HOT 1
- Provider downloads document content twice when syncing initially HOT 1
- Hang caused by not cleaning up Awareness in provider HOT 1
- Do collaboration history and auto-versioning work? HOT 1
- Add custome field to the Webhook
- Provider.disconnect prevents subsequent provider.connect from working HOT 1
- 2.10.0 breaks provider in nodejs HOT 8
- The server document judgment is always empty, resulting in duplicate data. HOT 2
- backend onChange undefined HOT 2
- Server crashed when webhook receives 400 status code response HOT 3
- Inaccurate document type check in onLoadDocument
- use lexical TypeError: The encoded data was not valid for encoding utf-8 HOT 1
- Updates made using openDirectConnection are not synchronizing changes across different Redis instances. HOT 9
- provider.destroy will reopen connection HOT 2
- About the actual storage size of documents during collaborative editing HOT 8
- An authentication token is required, but you didn’t send one - but token was actually included HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from hocuspocus.