Document name from context? about hocuspocus HOT 7 CLOSED

Hej Flávio.

Thanks a lot for your suggestion. I think it would be better to move the logic to get the document name into the listen() method itself and add a documentName parameter to handleConnection().

handleConnection(incoming: WebSocket, request: IncomingMessage, documentName: string, context: any = null): void

Using context for this feels kinda hacky and we are still on alpha, so changing the API is not a big deal for me. What do you think?

from hocuspocus.

Heya! Yeah sounds good, just need a way to pass this in, ideally the fewer arguments we have the better, but 4 is not too bad

from hocuspocus.

Cool. Will include it in the next release and drop you a line here when it's published. ;)

from hocuspocus.

Oops my bad, I had made some changes on the project structure, and forgot to move the .npmrc, works perfectly thanks!

from hocuspocus.

I just published @hocuspocus/[email protected] which includes this change. I also updated the documentation on the integration of express: https://www.hocuspocus.dev/guide/framework-integration/#express

Let me know, if you need more help! :)

from hocuspocus.

Thanks @kriskbx, tried installing but it's not working:
error Couldn't find package "@hocuspocus/[email protected]"

from hocuspocus.

Try putting it in your package.json and run yarn update or npm update:

{
    "dependencies": {
        "@hocuspocus/server": "^1.0.0-alpha.44"
    }
}

from hocuspocus.