Conditional jump or move depends on uninitialised value about nametag HOT 5 CLOSED

Many thanks for the fixes and your time. I've incorporated the changes and uploaded to CRAN. It's currently under CRAN review.
I tried to reproduce the valgrind issue myself but it depends clearly on valgrind 3.21.0 and I don't have an instrumented build of R-devel compiled with valgrind level 2 instrumentation alongside valgrind 3.21.0 to be able to reproduce it.

What I did already got as feedback from CRAN is that I had to replace std::interator as it is deprecated in C++17 and future compilers will not support C++11. I'll make a new issue for this if you don't mind.

I'll keep you updated here if I have more feedback from CRAN.

Found the following significant warnings:
  ./nametag/src/unilib/utf8.h:148:52: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
  ./nametag/src/unilib/utf8.h:180:52: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
  nametag/src/unilib/utf16.h:116:53: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
  nametag/src/unilib/utf16.h:148:53: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
  nametag/src/unilib/utf8.h:148:52: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]
  nametag/src/unilib/utf8.h:180:52: warning: 'template<class _Category, class _Tp, class _Distance, class _Pointer, class _Reference> struct std::iterator' is deprecated [-Wdeprecated-declarations]

from nametag.

The R package was accepted on CRAN yesterday including the fix for this issue which incorporated your changes of 294466f.
Yesterday CRAN tested as well with valgrind and the fix solved the problem.
Many thanks again!

from nametag.

Hi,

the issue is in the public-domain code performing LZMA (de)compression (we use it to compress the parts of the models where it make sense). The same code is also in UDPipe 1, MorphoDiTa, ... .

As you say, I am not sure how difficult will be to find the cause (given that it is someone else's code), but I will try to do it next week (and do minor releases with the fix).

from nametag.

That would be great! Thanks for the effort.

from nametag.

Hi,

after investigation, I believe it is just a false positive report by valgrind (the code actually does read an uninitialized value, but the conditional jump is guarded by other conditions, so the program behavior cannot be influenced by the unitialized value). I tried to fix the problem by ufal/cpp_utils@fc215c8 (on g++-10 and clang-11 the valgrind report disappeared) and then updated cpp_utils in nametag in the lastest commit 294466f.

Could you please try building the nametag R wrapper to verify the problem is really solved? Thanks!

from nametag.