Giter VIP home page Giter VIP logo

Comments (2)

ufrisk avatar ufrisk commented on July 17, 2024 1

The pIoPA->cbMax = 0x1000; is quite worriesome; this may lead to the pb buffer being overwritten past bounds. I have to look into this more and fix it somehow.

Generally I'd recommend using the VMMDLL_MemReadScatter with 0x1000-byte sized 0x1000-byte aligned scatter mem items only; it's the most well tested (or even the only properly tested internal paths).

Reads are latency bound anyway so unless doing 10+ reads or so in parallel having 0x1000 byte reads instead of an 8-byte read should not affect performance in any noticeable way.

I'll put this up as something I need to fix; meanwhile please use 0x1000 byte sized and aligned scatter read items.

from memprocfs.

ufrisk avatar ufrisk commented on July 17, 2024

I have changed how the ReadScatter works (re-designed the struct) so this should not be happening anymore.

Also, if reading on a page boundary when reading from an FPGA device it should now fail since it's not supported by PCI Express.

In general it still applies that the best way of going with things is to read page-aligned page-sized chunks of memory. There is very little performance improvement of reading smaller memory chunks.

from memprocfs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.