Sleep before TerminateProcess about memprocfs HOT 4 CLOSED

It's a 500ms wait, not a 1500ms wait, and there are some reasons for it.

The CreateThread creates a thread which performs some cleanup tasks. The cleanup task is started as a separate thread since it sometimes gets stuck / hangs - sometimes due to external libraries.

That is the reason why I create a separate thread with a Sleep afterwards instead of having all the cleanup tasks in the main thread alternatively wait for thread exit with the WaitForSingleObject.

The TerminateProcess is an async call and the process will normally terminate before the Sleep(1000) has executed any meaningful time. In total it's more equivalent to a ~500ms wait - which is kinda ok.

from memprocfs.

Hi @ufrisk , thank you for the response.

That is the reason why I create a separate thread

I understand that in reading your comment in the code, and

The TerminateProcess is an async call and the process will normally terminate before the Sleep(1000)

is ok (we are supposing that Sleep(1000) has very little change to be executed).

But I still don't understand why you've used Sleep, because such a piece:

CreateThread(...);
Sleep(500); // so it delays the process for 500ms

IMHO, can always be replaced (and probably better) by

HANDLE h = CreateThread(...);
WaitForSingleObject(h, 500); // so it delays the process for at most 500ms

from memprocfs.

Thanks 👍 I'll change it in the next version which I'll hopefully push some time in September (with full registry support).

from memprocfs.

Implemented, shutdown times are now noticeably faster. Thanks.

https://github.com/ufrisk/MemProcFS/blob/master/MemProcFS/memprocfs.c#L74

from memprocfs.