Giter VIP home page Giter VIP logo

Comments (5)

al1p avatar al1p commented on June 3, 2024

Hi, I added the missing in_trash variable here

Also, I had to hack a work-around when the "User" object has no type (and interrupt the recursion).

Tests are ok, but I'm not sure about other possible side-effects, I don't think this is ready for PR...

from ultimate-notion.

FlorianWilhelm avatar FlorianWilhelm commented on June 3, 2024

Hi @al1p, thanks! Sorry, that I haven't had a chance to look into this. There was quit a lot going on in the last weeks. Would you provide a PR?

In the next release, I'll also make sure that by default optional fields with Pydantic are allowed. The Notion API is still too much under development to keep them fixed.

from ultimate-notion.

al1p avatar al1p commented on June 3, 2024

Here you are : #30

from ultimate-notion.

FlorianWilhelm avatar FlorianWilhelm commented on June 3, 2024

Thank you @al1p.

So this is fixed on main branch and will be in the next release.

from ultimate-notion.

FlorianWilhelm avatar FlorianWilhelm commented on June 3, 2024

... thanks @hochbergg for reporting this issue and sorry for the long delay.

from ultimate-notion.

Related Issues (5)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.