Giter VIP home page Giter VIP logo

Comments (3)

ultrabug avatar ultrabug commented on July 29, 2024

Hi @frimdo

Thanks for this proposal, I think that this kind of module is indeed a good idea !

Maybe you could call this script external_script ? I have a few remarks wrt your code :

  • 1 second cache_timeout is a bit short and would hammer machines, maybe a default of 15 would be better
  • output_color could be called color, sounds simpler
  • make sure it runs with both python2 and python3 please and that it is PEP8 compliant
  • defaulting to whoami script sounds weird since there already is a whoami module available :) maybe provide no default and handle this properly on the code ?

from py3status.

frimdo avatar frimdo commented on July 29, 2024

OK, here is external_script, everything should work and be ready to go ;-)
The only one problem is line 31, that is too long (PEP8). I don't know how to make it shorter.
Hope you like it.

from py3status.

ultrabug avatar ultrabug commented on July 29, 2024

this module was added in your PR, closing

from py3status.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.