I have participated in some newer threads, and even received emails about new activity

Yeah, as <a class="user-mention notranslate" data-hovercard-type="user" data-hovercard

The "Activity in threads you participated in" list does not seem to be updating about ourumbraco HOT 4 CLOSED

umbraco commented on June 26, 2024 2

The "Activity in threads you participated in" list does not seem to be updating

from ourumbraco.

Comments (4)

BatJan commented on June 26, 2024

I experience that it's working kinda random...I see a mix of new and old threads in my list, which is quite confusing. Don't know if it may be a weird caching issue?

from ourumbraco.

greystate commented on June 26, 2024

Maybe it's just being ordered wrong?

I searched the source for "ACTIVITY IN THREADS YOU PARTICIPATED IN" and followed the rabbit to end up here:

OurUmbraco/OurUmbraco/Forum/Services/TopicService.cs

Lines 221 to 230 in 166329b

 var sql = new Sql().Select("TOP " + maxCount + " " + 

 @"forumTopics.*, u1.[text] as LastReplyAuthorName, u2.[text] as AuthorName, 

  forumComments.body as commentBody, forumComments.created as commentCreated, forumComments.haschildren,  

  forumComments.id as commentId, forumComments.isSpam as commentIsSpam, forumComments.memberId as commentMemberId, forumComments.parentCommentId, 

  forumComments.position, forumComments.score, forumComments.topicId") 

 .From("forumTopics") 

 .LeftOuterJoin("forumComments").On("forumTopics.id = forumComments.topicId") 

 .LeftOuterJoin("umbracoNode u1").On("(forumTopics.latestReplyAuthor = u1.id AND u1.nodeObjectType = '39EB0F98-B348-42A1-8662-E7EB18487560')") 

 .LeftOuterJoin("umbracoNode u2").On("(forumTopics.memberId = u2.id AND u2.nodeObjectType = '39EB0F98-B348-42A1-8662-E7EB18487560')") 

 .Where<Topic>(topic => topic.LatestReplyAuthor == memberId || topic.MemberId == memberId);

There's a couple of OrderByDescending() further down, but I don't know how it all works, so can't tell if there's caching involved or if the Topic.Updated could be in a wrong non-sortable format...

from ourumbraco.

villian commented on June 26, 2024

There is a 5 minutes cache for this block. I think it's confusing because of caching. Ordering made here:

            sql
                .OrderByDescending<Topic>(x => x.Updated)
                .OrderByDescending<Comment>(comment => comment.Created);

from ourumbraco.

nul800sebastiaan commented on June 26, 2024

Yeah, as @villian says it's due to caching. If anyone wants to take a stab at fixing it that would be cool, it should be possible to temporarily add things to the cache while we wait for it to expire I think, not sure?

For now I'll close it as it does work "eventually", but feel free to open a PR for this. I've put the idea label on it so we can revisit it later when we have some more time to spare.

from ourumbraco.

The "Activity in threads you participated in" list does not seem to be updating about ourumbraco HOT 4 CLOSED

Comments (4)

Related Issues (20)

Recommend Projects

React

Vue.js

Typescript

TensorFlow

Django

Laravel

D3

Recommend Topics

javascript

web

server

Machine learning

Visualization

Game

Recommend Org

Facebook

Microsoft

Google

Alibaba

D3

Tencent

	var sql = new Sql().Select("TOP " + maxCount + " " +
	@"forumTopics.*, u1.[text] as LastReplyAuthorName, u2.[text] as AuthorName,
	forumComments.body as commentBody, forumComments.created as commentCreated, forumComments.haschildren,
	forumComments.id as commentId, forumComments.isSpam as commentIsSpam, forumComments.memberId as commentMemberId, forumComments.parentCommentId,
	forumComments.position, forumComments.score, forumComments.topicId")
	.From("forumTopics")
	.LeftOuterJoin("forumComments").On("forumTopics.id = forumComments.topicId")
	.LeftOuterJoin("umbracoNode u1").On("(forumTopics.latestReplyAuthor = u1.id AND u1.nodeObjectType = '39EB0F98-B348-42A1-8662-E7EB18487560')")
	.LeftOuterJoin("umbracoNode u2").On("(forumTopics.memberId = u2.id AND u2.nodeObjectType = '39EB0F98-B348-42A1-8662-E7EB18487560')")
	.Where<Topic>(topic => topic.LatestReplyAuthor == memberId \|\| topic.MemberId == memberId);