Giter VIP home page Giter VIP logo

Comments (5)

leekelleher avatar leekelleher commented on August 16, 2024 1

@met67 Thanks for reporting... this has been fixed (in PR #123) for the next release, (we haven't set a release date yet).

from umbraco-nested-content.

leekelleher avatar leekelleher commented on August 16, 2024 1

@met67 If you need the fix now, then the latest package build is available on NuGet/MyGet:
https://www.myget.org/gallery/umbraco-packages

If you aren't using NuGet, then the Umbraco package zip can be downloaded from the latest AppVeyor build:
https://ci.appveyor.com/project/UMCO/umbraco-nested-content/build/artifacts

from umbraco-nested-content.

met67 avatar met67 commented on August 16, 2024

Thanks!

from umbraco-nested-content.

zpbd avatar zpbd commented on August 16, 2024

@leekelleher unfortunately I don't think this problem has gone away.

I've tried out your refactor of SayTen's PR, and for me this causes the dialog window to appear off the bottom of the tab, pushing the pane down. The user then needs to try to scroll down the page, but loses focus on the dialog whilst doing so. I've attached two screenshots to demonstrate.

For me, the original PR by SayTen is preferable and this is what I am using for now - the dialog is always fixed in the middle of the browser window. It looks odd because obviously it appears "over to the left" of the tab that you are editing, but at least it will always be visible.

.usky-grid.nested-content__node-type-picker .cell-tools-menu {
    position: fixed;
    left: 50%;
    top: 50%;
    transform: translate(-50%, -50%);
}

I think this needs resolving quickly in a release because a lot of people might be trying out Nested Content and just thinking it doesn't work if they add an NC property at the bottom of a long set of fields. Unfortunately I can't think of a satisfactory CSS-only solution. It might be simpler all around if the dialog appears instead as a pane that comes out from the right, this would also keep it consistent with the rest of the backoffice. Just a thought.

ncissue1

ncissue2

from umbraco-nested-content.

leekelleher avatar leekelleher commented on August 16, 2024

@zpbd Thanks for your comments, (I'm catching up after CG17). I've opened a new issue for this, so I will remember to review it, #132.

My issue with the modal being positioned in the middle/centre, is that it looked far too offset when using NC inside a side-panel, (such as DTGE). I wanted to keep it relative to the NC itself. I'm totally open to any improvements on this.

from umbraco-nested-content.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.