Giter VIP home page Giter VIP logo

Comments (7)

caifara avatar caifara commented on May 27, 2024 2

If you can hop on master, this was recently merged: #47

from motion.

jcoyne avatar jcoyne commented on May 27, 2024

@caifara Nice! I'll give that a try.

from motion.

jcoyne avatar jcoyne commented on May 27, 2024

@caifara master does work, however I was unable to call current_target on the event:

[TitleComponent:34660] An error occurred while processing add:
	NoMethodError: undefined method `current_target' for #<Motion::Event:0x00007fa0d8738b80>

however, I was able to switch to using target just fine.

from motion.

alecdotninja avatar alecdotninja commented on May 27, 2024

@jcoyne current_target was removed in #43 because I don't think it is what we ever wanted. On master (and in the next release), Motion::Event#element will always be the element to which data-motion was added.

I don't want to do a release until I track down what is causing the intermittent CI failures (especially since those are happening much more often now on master).

from motion.

jcoyne avatar jcoyne commented on May 27, 2024

@alecdotninja current_target is still referred to in the README. Should that be removed?

from motion.

alecdotninja avatar alecdotninja commented on May 27, 2024

@jcoyne Yes, that is a good idea. I really need to get better about documentation. 🙈

from motion.

alecdotninja avatar alecdotninja commented on May 27, 2024

#47 was released in 0.4.3 and the README has been updated 🎉

from motion.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.