Giter VIP home page Giter VIP logo

Comments (4)

UnexpectedMaker avatar UnexpectedMaker commented on June 25, 2024

This has been improved in v1.04 that I am going to upload today, but the abort button should never be able to be pressed outside of those states, so not sure why you need SetRelayFrequency(0); outside the if statement.

It is inside the if statement in v1.04 :-)

from reflowmaster.

tablatronix avatar tablatronix commented on June 25, 2024

It was a safety thing, in case of a bug or loss of state , abort aborts always

from reflowmaster.

UnexpectedMaker avatar UnexpectedMaker commented on June 25, 2024

Right, but again, AbortReflow() is only ever called from a button press, and that press can only happen in those states...

    else if ( state == 1 || state == 2 || state == 16 )
    {
      AbortReflow();
    }

from reflowmaster.

tablatronix avatar tablatronix commented on June 25, 2024

I am always thinking about future abstraction less code coverage if abort gets called from a big red button or tc failure

from reflowmaster.

Related Issues (17)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.