Giter VIP home page Giter VIP logo

Comments (8)

JohnLCaron avatar JohnLCaron commented on July 20, 2024

Hi Shane:

Thanks for reporting that, we will get it fixed. Are png files the only
ones you need to serve from there?

John

On Mon, Apr 6, 2015 at 12:14 AM, Shane StClair [email protected]
wrote:

In a change from previous versions (4.3.x), TDS seems to have lost the
ability to serve files in the public content directory other than css, gif,
and jpg files. The description in the docs doesn't mention this limitation.

http://www.unidata.ucar.edu/software/thredds/current/tds/reference/ThreddsConfigXMLFile.html#Server_Description

NOTE: The best way to use your own logo is to put it in the
${tomcat_home}/content/thredds/public/ directory, and specify it in
serverInformation as /thredds/

This seems to be the code restricting the extensions via a spring
RequestMapping pattern.

https://github.com/Unidata/thredds/blob/4.6.0/tds/src/main/java/thredds/server/root/RootController.java#L70

It also seems that subdirectories of public can't be used anymore either
(e.g. images subdirectory). These two changes bit us when upgrading to
4.6.0 from 4.3.20 as we used to serve a PNG logo image from
public/images/header.png.


Reply to this email directly or view it on GitHub
#115.

from thredds.

srstsavage avatar srstsavage commented on July 20, 2024

In an ideal world we could serve any file type (and subdirectories) from the public dir, either by explicitly including "public" in the path or by looking any unmapped URL in the public folder. But yes, for now we could get by with just *.png :)

from thredds.

JohnLCaron avatar JohnLCaron commented on July 20, 2024

ok, we are in some Spring mapping confusion but we will get it sorted out.

On Mon, Apr 6, 2015 at 1:06 PM, Shane StClair [email protected]
wrote:

In an ideal world we could serve any file type (and subdirectories) from
the public dir, either by explicitly including "public" in the path or by
looking any unmapped URL in the public folder. But yes, for now we could
get by with just *.png :)


Reply to this email directly or view it on GitHub
#115 (comment).

from thredds.

lesserwhirls avatar lesserwhirls commented on July 20, 2024

@JohnLCaron - did we get this fixed? If not, I'll add a ticket to jira.

from thredds.

JohnLCaron avatar JohnLCaron commented on July 20, 2024

i think its fixed

On Sat, May 30, 2015 at 8:48 PM, Sean Arms [email protected] wrote:

@JohnLCaron https://github.com/JohnLCaron - did we get this fixed? If
not, I'll add a ticket to jira.


Reply to this email directly or view it on GitHub
#115 (comment).

from thredds.

lesserwhirls avatar lesserwhirls commented on July 20, 2024

Ok, I'll close this issue for now. @shane-axiom - if the problem still exists in our latest release, can you let us know? Thanks!

from thredds.

lesserwhirls avatar lesserwhirls commented on July 20, 2024

Never mind...I'll just tag this as needs testing but keep it open...still trying to get a decent github workflow going here...

from thredds.

srstsavage avatar srstsavage commented on July 20, 2024

Tested 4.6.2, was able to serve a .png image in the public folder. Closing, thanks.

from thredds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.