Comments (10)
@cheryldmorse , would be useful to include a link to the NcML file you were testing?
from thredds.
I was using this dataset in the tests: http://sos.maracoos.org/stable/agg_catalogs/weatherflow_agg_catalog.html?dataset=wflow700-agg
from thredds.
Unfortunately, that link does not provide the actual NcML file that you're using, nor the datasets that that file aggregates. So, I can't really reproduce your issue at this point.
from thredds.
@cwardgar The datasets and NCML file are available here: https://www.dropbox.com/s/sqfvhu5ckyrzeo3/station_700_agg.zip?dl=0
Thank you.
from thredds.
Okay, I've reproduced the issue. On my machine, in fact, the execution times are more like:
v4.3.24: 1692ms
v4.6.0-SNAPSHOT: 14514ms
I'm looking into it now.
from thredds.
Okay, I've tracked down the issue to ucar.nc2.iosp.hdf5.DataBTree
In v4.3.24, memTracker is null, and thus no messages are added to it.
In v4.6.0-SNAPSHOT, memTracker is non-null, and many expensive messages are added to it (complicated toString() implementations, mostly)
Assigning null to memTracker in v4.6.0-SNAPSHOT reduces the calcBounds() time from 14514ms to 2488ms on my computer.
I suspect that memTracker should be disabled in a non-debug context, but I don't know for sure. @JohnLCaron, please advise.
from thredds.
Never mind, John, I can see here [1] that MemTracker is only supposed to be used for debugging. I'll just refactor the source to check the debugTracker flag before each and every use of MemTracker.
from thredds.
Fixed in 4.6.0.
from thredds.
good job. i likely enabled it when debugging, and/or fixing some coverity defect. the hashmap should be null in the non-debug case.
from thredds.
This has also been fixed in 4.5.5:
be28036
c4bd0f2
We'll try to release 4.5.5 soon.
from thredds.
Related Issues (20)
- Possible loop in thredds.client.catalog graph?
- Possible Issue with logging ResponseSize caused by insufficient storage type HOT 4
- variable attributes showing up in OPeNDAP global attributes! HOT 8
- Performance Issue with high variable and dimension count
- Thredds do not behave well behind Nginx proxy serving as SSL termination HOT 4
- Question regarding WCS DescribeCoverage ResponseCRSs HOT 4
- Wrong URL in description of this repository HOT 1
- Cross-Origin Read Blocking (CORB) blocked cross-origin response thredds HOT 2
- EOFException on NCDump data
- DAP4 in TDS dap4.core.util.DapException: Resource root not found HOT 3
- WMS GetMap Request with style=contour Returns Error HOT 14
- Unexpected behavior when querying area around Meridian HOT 2
- Date truncated by cast to long HOT 7
- NCML Time axis aggregation with missing / time gaps HOT 6
- double encoding of spaces in filenames when user click on "Get Binary" or "Get ASCII" in OPeNDAP download form HOT 5
- trimDirectiveWhitespaces breaking GetTransect HOT 3
- Unsigned types in NcML
- Tracking log4j security issues HOT 10
- blank Godiva2 basemap HOT 1
- WMS service broken in 4.6.19+ HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from thredds.