Giter VIP home page Giter VIP logo

Comments (10)

rsignell-usgs avatar rsignell-usgs commented on June 16, 2024

@cheryldmorse , would be useful to include a link to the NcML file you were testing?

from thredds.

cheryldmorse avatar cheryldmorse commented on June 16, 2024

I was using this dataset in the tests: http://sos.maracoos.org/stable/agg_catalogs/weatherflow_agg_catalog.html?dataset=wflow700-agg

from thredds.

cwardgar avatar cwardgar commented on June 16, 2024

Unfortunately, that link does not provide the actual NcML file that you're using, nor the datasets that that file aggregates. So, I can't really reproduce your issue at this point.

from thredds.

cheryldmorse avatar cheryldmorse commented on June 16, 2024

@cwardgar The datasets and NCML file are available here: https://www.dropbox.com/s/sqfvhu5ckyrzeo3/station_700_agg.zip?dl=0
Thank you.

from thredds.

cwardgar avatar cwardgar commented on June 16, 2024

Okay, I've reproduced the issue. On my machine, in fact, the execution times are more like:
v4.3.24: 1692ms
v4.6.0-SNAPSHOT: 14514ms

I'm looking into it now.

from thredds.

cwardgar avatar cwardgar commented on June 16, 2024

Okay, I've tracked down the issue to ucar.nc2.iosp.hdf5.DataBTree

In v4.3.24, memTracker is null, and thus no messages are added to it.
In v4.6.0-SNAPSHOT, memTracker is non-null, and many expensive messages are added to it (complicated toString() implementations, mostly)

Assigning null to memTracker in v4.6.0-SNAPSHOT reduces the calcBounds() time from 14514ms to 2488ms on my computer.

I suspect that memTracker should be disabled in a non-debug context, but I don't know for sure. @JohnLCaron, please advise.

from thredds.

cwardgar avatar cwardgar commented on June 16, 2024

Never mind, John, I can see here [1] that MemTracker is only supposed to be used for debugging. I'll just refactor the source to check the debugTracker flag before each and every use of MemTracker.

[1] https://github.com/Unidata/thredds/blob/v4.5.4/cdm/src/main/java/ucar/nc2/iosp/hdf5/H5header.java#L222

from thredds.

cwardgar avatar cwardgar commented on June 16, 2024

Fixed in 4.6.0.

from thredds.

JohnLCaron avatar JohnLCaron commented on June 16, 2024

good job. i likely enabled it when debugging, and/or fixing some coverity defect. the hashmap should be null in the non-debug case.

from thredds.

cwardgar avatar cwardgar commented on June 16, 2024

This has also been fixed in 4.5.5:
be28036
c4bd0f2

We'll try to release 4.5.5 soon.

from thredds.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.