Changing some enums to scriptable objects about com.unity.multiplayer.samples.coop HOT 8 CLOSED

Hey @tuleky thank you for this!
Please go ahead!
The only advice we'd give you is create smaller PRs for your individual features against the develop branch. (for example one PR for character data)
This'll be great to continue the conversation, see what you have in mind.

from com.unity.multiplayer.samples.coop.

I couldn't find a way to change those enum to scriptable objects, I think the reason is I haven't known multiplayer architecture well, sending huge CharacterClass via networkvariable every tick is so inefficient, we definitely have to use enum in this scenario.

One suggestion would be I think we don't networkvariable for syncing character classes for late joiners, there could be a little system which sends character classes to the new comers via rpc calls rather than networkvariable. That way we could use CharacterClass for sending data over network.

from com.unity.multiplayer.samples.coop.

Hey Tuleky! A quick solution for this, you could generate an ID dynamically (in your SO's OnValidate if it's not generated yet). That would give a way to identify SOs and be able to exchange only that ID on the network. What do you think?

from com.unity.multiplayer.samples.coop.

I would highly suggest keeping NetVars for that kind of data instead of RPCs. (See this article here on why https://docs-multiplayer.unity3d.com/docs/learn/rpcvnetvar)

from com.unity.multiplayer.samples.coop.

Hey Tuleky! A quick solution for this, you could generate an ID dynamically (in your SO's OnValidate if it's not generated yet). That would give a way to identify SOs and be able to exchange only that ID on the network. What do you think?

Hmm, that sounds nice. So we still need some kind of dictionary implementation for finding character class via using ID, what would we gain for doing that?

from com.unity.multiplayer.samples.coop.

The advantage is you wouldn't need an enum with a switch case. It could be populated dynamically. It would allow to add new classes or actions without code changes

from com.unity.multiplayer.samples.coop.

We also need a solution for imps, they need to be set up before launch.

from com.unity.multiplayer.samples.coop.

fixed

from com.unity.multiplayer.samples.coop.