Giter VIP home page Giter VIP logo

Comments (9)

brianlagunas avatar brianlagunas commented on July 23, 2024

Actually, this looks like this is related to the interface of IUnityContainer changing, which seems to have broken Prism. Still investigating.

from abstractions.

ENikS avatar ENikS commented on July 23, 2024

Could you be more specific: what is failing and under what circumstances.
The code you referring to is working fine in all existing tests. Granted these are the original tests and only cover 87% of code...

Could you give me a test case where it fails?

from abstractions.

brianlagunas avatar brianlagunas commented on July 23, 2024

This test fails: https://github.com/PrismLibrary/Prism/blob/master/Source/Wpf/Prism.Unity.Wpf.Tests/UnityServiceLocatorAdapterFixture.cs#L34

This actually seems to be related to the fact that the IUnityContainer interface was changed. ResolveAll is no longer on the interface, which means the new extension method is being used instead of the interface method (which has been removed), hence breaking our tests.

Do you have a list of all the breaking changes you have made?

from abstractions.

ENikS avatar ENikS commented on July 23, 2024

Looking at the coverage date I can see it is being tested properly: https://codecov.io/gh/unitycontainer/unity/src/master/src/Unity/Container/UnityContainerExtensions.cs

from abstractions.

ENikS avatar ENikS commented on July 23, 2024

I listed all breaking changes in release notes every time there was a change.

from abstractions.

brianlagunas avatar brianlagunas commented on July 23, 2024

I don't see them:

https://github.com/unitycontainer/abstractions/releases

https://github.com/unitycontainer/container/releases

Should I be looking somewhere else?

from abstractions.

ENikS avatar ENikS commented on July 23, 2024

I see the problem. Mocks will not work.

from abstractions.

ENikS avatar ENikS commented on July 23, 2024

https://github.com/unitycontainer/unity/releases

Did not have time to update these everywhere

from abstractions.

brianlagunas avatar brianlagunas commented on July 23, 2024

I see... I will have to find a way to update my tests to account for all the breaking changes.

from abstractions.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.