Comments (9)
Actually, this looks like this is related to the interface of IUnityContainer changing, which seems to have broken Prism. Still investigating.
from abstractions.
Could you be more specific: what is failing and under what circumstances.
The code you referring to is working fine in all existing tests. Granted these are the original tests and only cover 87% of code...
Could you give me a test case where it fails?
from abstractions.
This test fails: https://github.com/PrismLibrary/Prism/blob/master/Source/Wpf/Prism.Unity.Wpf.Tests/UnityServiceLocatorAdapterFixture.cs#L34
This actually seems to be related to the fact that the IUnityContainer interface was changed. ResolveAll is no longer on the interface, which means the new extension method is being used instead of the interface method (which has been removed), hence breaking our tests.
Do you have a list of all the breaking changes you have made?
from abstractions.
Looking at the coverage date I can see it is being tested properly: https://codecov.io/gh/unitycontainer/unity/src/master/src/Unity/Container/UnityContainerExtensions.cs
from abstractions.
I listed all breaking changes in release notes every time there was a change.
from abstractions.
I don't see them:
https://github.com/unitycontainer/abstractions/releases
https://github.com/unitycontainer/container/releases
Should I be looking somewhere else?
from abstractions.
I see the problem. Mocks will not work.
from abstractions.
https://github.com/unitycontainer/unity/releases
Did not have time to update these everywhere
from abstractions.
I see... I will have to find a way to update my tests to account for all the breaking changes.
from abstractions.
Related Issues (20)
- RegisterFactory delegate should be able to call the original Resolve with overrides HOT 1
- FactoryLifetime.Scoped has wrong return type
- Fix InjectionConstructor & InjectionMethod selection with Type vs parameter of Type
- Unity.Abstractions 5.11.6 not working with Unity.AspNet.WebApi 5.0.15? HOT 3
- PerSessionLifetimeManager no longer works after upgrading to Unity.Abstraction 5.11 HOT 4
- Method "ToString" does not have an implementation exception Unity versions 5.11.8 and 5.11.9 HOT 4
- Document Unity Release versioning strategy HOT 9
- Add missing constructors to DependencyOverride<T>
- ECCN question HOT 1
- XML documentation question HOT 1
- How to return the old behaviour of Unity registration/resolve processes HOT 1
- Add name validation for PropertyOverride and FieldOverride
- DependencyOverride incorrect matches
- Remove obsolete class TypeBasedOverride
- Optimize ResolverOverride
- Fix ParameterOverrides.OnType(Type targetType)
- Resolve fails when registered with nested injection
- Unity.Extensions.Inject does not cover all cases for Arrays, Parameters, and members
- ILifetimeContainer interface changes
- Changes to IResolveContext interface
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abstractions.