$fetch using `globalThis` (not the polyfill) about ofetch HOT 6 CLOSED

@pi0 I'm not adding a polyfill, im referring to the globalThis polyfill (or shim?), which is right in the ohmyfetch codebase, and that's cool, but one place uses the globalThis shim, but another place doesn't:

This line ends up in the nuxt3 build: https://github.com/unjs/ohmyfetch/blob/4b74e45f9989a993e725e7fe4d2e098442e457f1/src/undici.ts#L7

Browsers that dont support globalThis will just fail on that. But this: https://github.com/unjs/ohmyfetch/blob/4b74e45f9989a993e725e7fe4d2e098442e457f1/src/index.ts#L6-L14 uses the polyfill/shim.

So should the following also use the polyfill (basically _globalThis vs globalThis; and move the shim to some shared util file)? https://github.com/unjs/ohmyfetch/blob/4b74e45f9989a993e725e7fe4d2e098442e457f1/src/undici.ts#L7

from ofetch.

Nuxt 3 does not add a fetch polyfill for browsers. Are you doing this by yourself?

from ofetch.

@pi0 would be a nice, simple fix (i imagine) that would open up a few more supported browsers.

If this gets cleared, and my app still needs other polyfills, then thats a different story, but currently this is a fixable issue that blocks asserting which browsers work/need other polyfills, etc.

from ofetch.

/undici and /node subpath exports are only for Node.js and SSR, I'm afraid using fallabck globalThis refs there wouldn't solve safari issue neither needed for Node >= 12.

A simple reproduction and excat safari version would be helpful.

from ofetch.

I was gonna say, it might not even necessarily be that the polyfill is needed, but that that part of the code shouldn't be part of the client build in general (maybe that's the issue?) The undici path is leaking into the client build but shouldnt be?

Maybe a boilerplate stackblitz of nuxt3 would repro the issue..

Safari 11.1.2

It's not urgent, but like I said, it would cool for nuxt and my app to possibly be able to work on a few other browsers if this issue gets fixed; who konws, maybe this is the only issue on this safari version and everything ends up working fine.

from ofetch.

Hi. Sorry this issue is stalled. I believe with latest versions, we strictly use polyfills from node-fetch-natvie but please ping me to reopen if still have issues.

from ofetch.