Giter VIP home page Giter VIP logo

Comments (3)

christynwegner avatar christynwegner commented on June 7, 2024 1

I know this is an old thread but in 2021 I had this issue, too; eslint should have errored for us but instead passed eslint and allowed commit. This also meant CI/CD also passed. We used the same configuration in the README.

"tsc/config": [1, {
    configFile: "tsconfig.json"
}]

Manually running yarn eslint ... on the problem file output (instead of through lint-staged on pre-commit) output warnings which allowed linting to pass.

After changing the config rule to error (or, as I recently discovered 2 = error, 1 = warn) , eslint now fails as expected and now fails both pre-commit and CI/CD linting:

"tsc/config": ["error", {
    configFile: "tsconfig.json"
}]

from eslint-plugin-tsc.

unlight avatar unlight commented on June 7, 2024

Interesting.
Cannot tell what is reason of such behavior.
Can you show your tsconfig?

from eslint-plugin-tsc.

rumanHuq avatar rumanHuq commented on June 7, 2024

for typescript files you need to explicitly pass the extensions
eslint . --ext .js,.jsx,.ts,.tsx

from eslint-plugin-tsc.

Related Issues (2)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.