Comments (7)
I've seen one other case where slashes where used (inlining templates in AngularJS).
If it is valid HTML5 we should make some effort to support it with the [id="test/test"]
approach.
I believe this could be a small change here:
from unpoly.
If it is valid HTML5 we should make some effort to support it with the [id="test/test"] approach.
Maybe only do that if it is an invalid #...
selector as I think doing it that way is slightly slower? The regex I gave above should be able to detect it fine as that was the old HTML4 standard.
from unpoly.
That might be because /
is invalid in HTML4 and earlier (although the restriction was lifted in HTML5 I just found out). Initially (and if you want to be sure it works in all browsers) the HTML id
attribute is restricted to the set of [a-zA-Z0-9_-]
Using /
would be especially problematic as it could prevent an id from being referenced from HTML as well as it could be inferred as a URL path instead of a DOM id depending on implementation.
from unpoly.
I'm assuming submitting such a form would trigger a replacement for form#test/test
, which is an invalid CSS selector.
@foobear What's your use case for using slashes in IDs?
from unpoly.
Good point. While form#test/test
is an invalid CSS selector, the form ID would still be valid HTML5.
Maybe Unpoly could transform its "default" selector generated by the form ID to something that works, like form[id="test/test"]
. However, I am not sure if this could cover all cases and if Unpoly would need to do it.
Throwing an error would be fine for me. Since jQuery or document.querySelector
cause an error, I'd have expected to see one, too.
The slashes in IDs already existed in the application "because of reasons". In this case I could change the application to not use slashes in IDs.
from unpoly.
Yeah, definitely only when there's a weird character in the ID.
from unpoly.
Will be fixed in the next release.
from unpoly.
Related Issues (20)
- CSP blocking `up.reload` even with `unsafe-eval` HOT 4
- Submit via out-of-form element does not contribute the element name/value pair HOT 2
- DOMException: Failed to execute 'matches' on 'Element': ':none' is not a valid selector. HOT 3
- While in an overlay, Unpoly 3 injects a form fragment outside [up-target] after onBlur validation HOT 6
- Cannot submit form containing a field called "contains" in Unpoly 3 HOT 3
- Allow custom navigation feedback HOT 7
- Redirect to new URL
- Wrong cursor position on up-autosubmit form with field type="number" HOT 1
- Using up.on with the passive option set to true raises an unexpected error HOT 2
- tiny doc opt: new changes accessible on github HOT 1
- Doc: dead link in url-patterns
- up-alias not matching URL query string with asterix after shash HOT 2
- https://unpoly.com/ broken HOT 2
- Little documentation typo: `Sxee` instead of `See`
- nested up-hungry removes inner hungry elements HOT 1
- per page css
- Hide focus ring when following an [up-instant] link HOT 1
- Please support `up.reload(":none")` HOT 3
- Respect unpoly attributes on form submitters HOT 2
- snipcart with unpoly HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from unpoly.