Giter VIP home page Giter VIP logo

Comments (7)

triskweline avatar triskweline commented on May 28, 2024 1

I've seen one other case where slashes where used (inlining templates in AngularJS).

If it is valid HTML5 we should make some effort to support it with the [id="test/test"] approach.

I believe this could be a small change here:

selectorForElement = (element) ->

describe 'up.util.selectorForElement', ->

from unpoly.

OvermindDL1 avatar OvermindDL1 commented on May 28, 2024 1

If it is valid HTML5 we should make some effort to support it with the [id="test/test"] approach.

Maybe only do that if it is an invalid #... selector as I think doing it that way is slightly slower? The regex I gave above should be able to detect it fine as that was the old HTML4 standard.

from unpoly.

OvermindDL1 avatar OvermindDL1 commented on May 28, 2024

That might be because / is invalid in HTML4 and earlier (although the restriction was lifted in HTML5 I just found out). Initially (and if you want to be sure it works in all browsers) the HTML id attribute is restricted to the set of [a-zA-Z0-9_-]

Using / would be especially problematic as it could prevent an id from being referenced from HTML as well as it could be inferred as a URL path instead of a DOM id depending on implementation.

from unpoly.

triskweline avatar triskweline commented on May 28, 2024

I'm assuming submitting such a form would trigger a replacement for form#test/test, which is an invalid CSS selector.

@foobear What's your use case for using slashes in IDs?

from unpoly.

foobear avatar foobear commented on May 28, 2024

Good point. While form#test/test is an invalid CSS selector, the form ID would still be valid HTML5.

Maybe Unpoly could transform its "default" selector generated by the form ID to something that works, like form[id="test/test"]. However, I am not sure if this could cover all cases and if Unpoly would need to do it.
Throwing an error would be fine for me. Since jQuery or document.querySelector cause an error, I'd have expected to see one, too.

The slashes in IDs already existed in the application "because of reasons". In this case I could change the application to not use slashes in IDs.

from unpoly.

triskweline avatar triskweline commented on May 28, 2024

Yeah, definitely only when there's a weird character in the ID.

from unpoly.

triskweline avatar triskweline commented on May 28, 2024

Will be fixed in the next release.

from unpoly.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.