es_search should reject NULL passed to index about uptasticsearch HOT 4 CLOSED

Those are great points. Thanks for explaining.

from uptasticsearch.

Sounds good, though we should clarify that in the docs too.

from uptasticsearch.

Do you think that there should be a .ValidateAndFormatIndex function? What about validation on trailing_args and query_body?

Is the problem with allowing a user to pass NULL as the index that the resulting query might take a very long time, since it is searching over all indexes?

from uptasticsearch.

@mfrasco I'm not a .ValidateAndFormatIndex is right for this particular issue. Not passing an index is "valid".

I also want to avoid validating queries because the query DSL changes radically from major ES version to major ES version. We've explicitly tried to keep the scope of this project to the execution or requests and parsing of results.

My concern isn't explicitly that the query will take too long, since the query-all-indices use case should definitely be something we support. My thinking is that allowing NULL means that you can find yourself in that world silently. Forcing people to use "_all" is safer.

FWIW I hit this when I was trying to subset into the output from get_fields() then pipe the result of that to es_host. I wrote a bad subset condition which silently evaluated to NULL, and then noticed in the log that es_search was trying to pull WAY more data than I expected.

from uptasticsearch.