Comments (3)
Hey @musicinmybrain, thanks for this. And as a Fedora user, thanks for your packaging work! We switched to Hypercorn because it supports HTTP/2 (unlike Tornado), so switching back isn't an option. Sorry that this causes you more work. :( We definitely want to merge our changes upstream, but had little success so far. The urllib3-changes branch contains three important changes for us:
- Support for the ASGI TLS extension. The current support is partial because it's what urllib3 needed, but I'm happy to contribute complete support. It's computationally expensive, so probably needs to be behind a a configuration option.
- Access to the underlying transport, which I also implemented as an ASGI extension, though no spec currently exists for this. It was the only way to implement CONNECT, which we need to test our proxy support. It seems reasonable to include to me, and the leading underscore makes it clear that no guarantee exists.
- Fail loudly in case of h11/h2 errors. The default behavior is to drop errors silently, which makes debugging extremely difficult. I'm happy to put this behind an option too.
@pgjones What do you think about the above? How can we best help you add those features? We can direct some of our HTTP/2 funding to Hypercorn work on those three issues.
from urllib3.
Thank you for writing a full and clear explanation in one place!
I have a working proof of concept for introducing python-hypercorn
, python-quart
, and python-quart-trio
packages to Fedora, and then using PYTHONPATH
manipulation to interpose a bundled copy of the forked Hypercorn while running the tests in the python-urllib3
package build. Subject to further review and input from other Fedora packagers, I think that will be the path forward for now.
from urllib3.
- I'm not sure the ASGI TLS extension can be implemented in full - last time I looked a lot of the aspects weren't possible. I think the ASGI extension specification needs to be rewritten to account for this.
- & 3. I need to think about these, I had in general not wanted to deviate from the ASGI spec with custom features. I'm more open to 3, as I think the ASGI scope should be simple str/bytes only.
My general issue is time, of which I have very little. PRs are welcome though.
from urllib3.
Related Issues (20)
- Allow HTTP/2 connection and socket to be re-used for future requests
- Add support for sending a request body with HTTP/2 HOT 1
- Add support for using HTTP/2 without TLS or prior knowledge HOT 1
- pypy tests often fail in CI with reason "cancelled after 30 minutes"
- Comply with TLS settings mandated for HTTP/2 in RFC 9113
- Upgrade mypy to the latest version in CI HOT 1
- Fix type checking when Zstandard is installed
- Move length_remaining into BaseHTTPResponse HOT 1
- Slow test cases on pypy3.9-7.3.15 on Ubuntu 22.04
- TLS 1.3 Post Handshake Auth no longer working with urllib 2.1.0 when ignoring cert validation HOT 1
- Create a workflow (nox?) for testing Emscripten support locally
- Emscripten support emits an InsecureRequestWarning even when using HTTPS
- Handle HTTP/2 informational responses (1xx) HOT 2
- urllib3 2.2 explicitly casts all headers to HTTPHeaderDict HOT 4
- Streaming responses using urllib3 HOT 5
- verbose logging output
- Excess leading path separators causes ConnectionPool.urlopen to parse URL as host & port HOT 1
- ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response')) HOT 1
- SSL: UNEXPECTED_EOF_WHILE_READING HOT 7
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from urllib3.