Comments (2)
Yes this is a known pattern and a number of things have been tried over the years. In general profiling a JVM for CPU in apps that are not CPU-bound is not worth it. Most jsip apps I've seen are memory bound. I remember avoiding intern() had an adverse effect on garbage collection. You may gain some speed until the first major GC event hits you. And garbage collection is not subject to a Java profiler so it gives inaccurate results.
Not familiar with the results of this particular patch here but it's possible that without synchronisation it had some issues, while with synchro it would be similar to intern().
There are new garbage collectors now and it may be worth re-examining the issue, however I wouldn't trust a JVM profiler to conclude this is a bottleneck, this needs a native profiler to capture GC codepaths under sustained load. You may be trading CPU for GC stress.
from jsip.
Thanks for the quick reply, that's all interesting.
I didn't appear to see major GC trade-offs when performing the same tests without the SIPHeader
.intern()
, but that was still with Jprofiler which only shows general GC activity. (And a JVM running with the G1 GC, FWIT).
Interesting point about using a native profiler to get a better GC picture, thanks.
from jsip.
Related Issues (20)
- What is jain-sip-ri represent for ? HOT 3
- Adding header to previous empty value results in incorrectly formatted message HOT 5
- Ack getting dropped during glare. HOT 3
- TCP transport is not working after version 1.2.324 HOT 10
- Calling SipStackImpl::createSipProvider() after SipStackImpl::start() HOT 2
- Expires and Min-Expires SIP headers break for large values HOT 3
- jsip is checking the sdp from the final response and not from provisional response HOT 3
- TCP RST on Stale Socket HOT 2
- Support for multiple P-Access-Network-Info header in a sip message HOT 4
- P-Access-Network-Info header's ABNF is corrected by RFC7913 which has to be updated in stack HOT 2
- General query : Why don't we align the bug fixes of RestComm/jain-sip to Unistgov/jsip HOT 1
- Question about evolving build to a more recent Java version and full maven structure HOT 8
- Android sources missing HOT 1
- AcceptLanguageParserTest is in failure HOT 2
- log4shell (log4j update to log4j 2.16.0) CVE-2021-4104 CVE-2021-44228 HOT 2
- TCP thread conccurency/synchronization issue HOT 5
- Deadlock in SIPServerTransactionImpl ?
- Need for an ability to know whether a SipMessage is Retransmitted (SipRequest or SipResponse) and log the sip message HOT 2
- Need to configure TimerB
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from jsip.